fpdfsdk/src/fpdfsave.cpp - Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdfsave.cpp

Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/fpdfsave.cpp

diff --git a/fpdfsdk/src/fpdfsave.cpp b/fpdfsdk/src/fpdfsave.cpp

index 6637c784fe17e9e3945a7fef9d51ed45fcadaf8d..8025946ba8e589bfc7bb14b40f34bbb5f94b5c89 100644

--- a/fpdfsdk/src/fpdfsave.cpp

+++ b/fpdfsdk/src/fpdfsave.cpp

@@ -13,7 +13,7 @@

#include <ctime>

#endif

-class CFX_IFileWrite:public IFX_StreamWrite

+class CFX_IFileWrite FX_FINAL : public IFX_StreamWrite

{

public:

« fpdfsdk/src/fpdfeditpage.cpp ('K') | « fpdfsdk/src/fpdfeditpage.cpp ('k') | fpdfsdk/src/fpdfview.cpp » ('j') | no next file with comments »