Chromium Code Reviews| Index: Source/core/page/EventHandler.cpp |
| diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp |
| index f02bbce05b9e47279bc664e816faf680e84d7f20..79956b0158dee29af57b8dabe41a962deb5deb0a 100644 |
| --- a/Source/core/page/EventHandler.cpp |
| +++ b/Source/core/page/EventHandler.cpp |
| @@ -2490,18 +2490,10 @@ bool EventHandler::bestClickableNodeForHitTestResult(const HitTestResult& result |
| WillBeHeapVector<RefPtrWillBeMember<Node>, 11> nodes; |
| copyToVector(result.rectBasedTestResult(), nodes); |
| - // FIXME: Should be able to handle targetNode being a shadow DOM node to avoid performing uncessary hit tests |
| - // in the case where further processing on the node is required. Returning the shadow ancestor prevents a |
| - // regression in touchadjustment/html-label.html. Some refinement is required to testing/internals to |
| - // handle targetNode being a shadow DOM node. |
| - |
| // FIXME: the explicit Vector conversion copies into a temporary and is wasteful. |
| // FIXME: targetNode and success are only used by Internals functions. We should |
|
Zeeshan Qureshi
2014/07/05 03:22:13
Will remove this comment too before landing.
Rick Byers
2014/07/07 18:25:44
Yeah I don't think it's true for 'targetNode' anym
Zeeshan Qureshi
2014/07/09 16:10:15
Done.
|
| // instead have dedicated test methods so we only do this work in tests. |
| - bool success = findBestClickableCandidate(targetNode, targetPoint, touchCenter, touchRect, WillBeHeapVector<RefPtrWillBeMember<Node> > (nodes)); |
| - if (success && targetNode) |
| - targetNode = targetNode->deprecatedShadowAncestorNode(); |
| - return success; |
| + return findBestClickableCandidate(targetNode, targetPoint, touchCenter, touchRect, WillBeHeapVector<RefPtrWillBeMember<Node> > (nodes)); |
| } |
| bool EventHandler::bestContextMenuNodeForHitTestResult(const HitTestResult& result, IntPoint& targetPoint, Node*& targetNode) |