Allow touch adjustment to return Shadow DOM node.

Source/core/page/EventHandler.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 2472 matching lines @@
     // scrollbars being untouchable.
     if (result.scrollbar())
         return false;
 
     IntPoint touchCenter = m_frame->view()->contentsToWindow(result.roundedPointInMainFrame());
     IntRect touchRect = m_frame->view()->contentsToWindow(result.hitTestLocation().boundingBox());
 
     WillBeHeapVector<RefPtrWillBeMember<Node>, 11> nodes;
     copyToVector(result.rectBasedTestResult(), nodes);
 
-    // FIXME: Should be able to handle targetNode being a shadow DOM node to avoid performing uncessary hit tests
-    // in the case where further processing on the node is required. Returning the shadow ancestor prevents a
-    // regression in touchadjustment/html-label.html. Some refinement is required to testing/internals to
-    // handle targetNode being a shadow DOM node.
-
     // FIXME: the explicit Vector conversion copies into a temporary and is wasteful.
     // FIXME: targetNode and success are only used by Internals functions. We should

[Zeeshan Qureshi, 2014/07/05 03:22:13]

Will remove this comment too before landing.

[Rick Byers, 2014/07/07 18:25:44]

Yeah I don't think it's true for 'targetNode' anymore - I changed the code to
store the targetNode in the hitTestResults (probably only when success is true).
 Really this design was a symptom of requiring extra hit tests for touch
adjustment.  So remove away....

[Zeeshan Qureshi, 2014/07/09 16:10:15]

Done.

     // instead have dedicated test methods so we only do this work in tests.
-    bool success = findBestClickableCandidate(targetNode, targetPoint, touchCenter, touchRect, WillBeHeapVector<RefPtrWillBeMember<Node> > (nodes));
-    if (success && targetNode)
-        targetNode = targetNode->deprecatedShadowAncestorNode();
-    return success;
+    return findBestClickableCandidate(targetNode, targetPoint, touchCenter, touchRect, WillBeHeapVector<RefPtrWillBeMember<Node> > (nodes));
 }
 
 bool EventHandler::bestContextMenuNodeForHitTestResult(const HitTestResult& result, IntPoint& targetPoint, Node*& targetNode)
 {
     ASSERT(result.isRectBasedTest());
     IntPoint touchCenter = m_frame->view()->contentsToWindow(result.roundedPointInMainFrame());
     IntRect touchRect = m_frame->view()->contentsToWindow(result.hitTestLocation().boundingBox());
     WillBeHeapVector<RefPtrWillBeMember<Node>, 11> nodes;
     copyToVector(result.rectBasedTestResult(), nodes);
 
@@ skipping 1302 matching lines @@
 unsigned EventHandler::accessKeyModifiers()
 {
 #if OS(MACOSX)
     return PlatformEvent::CtrlKey | PlatformEvent::AltKey;
 #else
     return PlatformEvent::AltKey;
 #endif
 }
 
 } // namespace WebCore