Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 370803002: Return transform from transformationForTextBox instead of using out-param (Closed)

Created:
6 years, 5 months ago by fs
Modified:
6 years, 5 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Return transform from transformationForTextBox instead of using out-param Also simplify SVGTextChunkBuilder::transformationForTextBox while in the neighborhood. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177774

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M Source/core/rendering/svg/SVGTextChunkBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextChunkBuilder.cpp View 1 chunk +2 lines, -8 lines 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutEngine.cpp View 1 chunk +1 line, -2 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
fs
As touched upon in https://codereview.chromium.org/362923007/
6 years, 5 months ago (2014-07-04 13:19:26 UTC) #1
fs
On 2014/07/04 13:19:26, fs wrote: > As touched upon in https://codereview.chromium.org/362923007/ Ping.
6 years, 5 months ago (2014-07-08 17:59:16 UTC) #2
pdr.
Sorry about the delay. LGTM with a question. https://codereview.chromium.org/370803002/diff/1/Source/core/rendering/svg/SVGTextLayoutEngine.cpp File Source/core/rendering/svg/SVGTextLayoutEngine.cpp (right): https://codereview.chromium.org/370803002/diff/1/Source/core/rendering/svg/SVGTextLayoutEngine.cpp#newcode297 Source/core/rendering/svg/SVGTextLayoutEngine.cpp:297: AffineTransform ...
6 years, 5 months ago (2014-07-08 19:00:44 UTC) #3
fs
https://codereview.chromium.org/370803002/diff/1/Source/core/rendering/svg/SVGTextLayoutEngine.cpp File Source/core/rendering/svg/SVGTextLayoutEngine.cpp (right): https://codereview.chromium.org/370803002/diff/1/Source/core/rendering/svg/SVGTextLayoutEngine.cpp#newcode297 Source/core/rendering/svg/SVGTextLayoutEngine.cpp:297: AffineTransform textBoxTransformation = m_chunkLayoutBuilder.transformationForTextBox(textBox); On 2014/07/08 19:00:44, pdr wrote: ...
6 years, 5 months ago (2014-07-09 08:53:53 UTC) #4
pdr.
On 2014/07/09 08:53:53, fs wrote: > https://codereview.chromium.org/370803002/diff/1/Source/core/rendering/svg/SVGTextLayoutEngine.cpp > File Source/core/rendering/svg/SVGTextLayoutEngine.cpp (right): > > https://codereview.chromium.org/370803002/diff/1/Source/core/rendering/svg/SVGTextLayoutEngine.cpp#newcode297 > ...
6 years, 5 months ago (2014-07-09 19:12:35 UTC) #5
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 5 months ago (2014-07-09 19:12:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/370803002/1
6 years, 5 months ago (2014-07-09 19:13:39 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 21:18:03 UTC) #8
Message was sent while issue was closed. 
Change committed as 177774

Powered by Google App Engine
This is Rietveld 408576698