Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 370623002: Remove most of NetworkUIData. (Closed)

Created:
6 years, 5 months ago by pneubeck (no reviews)
Modified:
6 years, 5 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove most of NetworkUIData. As client certificate information is now retrieved from policy, most of NetworkUIData can be removed except ONCSource to indicate whether a network was managed after the policy got removed. BUG=391292 R=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282038

Patch Set 1 : #

Total comments: 7

Patch Set 2 : Rebased. #

Patch Set 3 : Addressed comments, removed more dead code. #

Patch Set 4 : Fixed compilation #

Patch Set 5 : Removed yet-another unused function. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -513 lines) Patch
M chrome/browser/chromeos/enrollment_dialog_view.cc View 1 2 3 3 chunks +27 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/net/onc_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/certificate_pattern.h View 1 2 3 4 chunks +4 lines, -10 lines 0 comments Download
M chromeos/network/certificate_pattern.cc View 1 2 3 4 3 chunks +0 lines, -49 lines 0 comments Download
M chromeos/network/client_cert_resolver.cc View 1 6 chunks +12 lines, -72 lines 0 comments Download
M chromeos/network/client_cert_util.h View 1 2 4 chunks +22 lines, -1 line 0 comments Download
M chromeos/network/client_cert_util.cc View 1 2 3 4 chunks +81 lines, -2 lines 0 comments Download
M chromeos/network/network_connection_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chromeos/network/network_connection_handler.cc View 1 2 3 6 chunks +24 lines, -13 lines 0 comments Download
M chromeos/network/network_connection_handler_unittest.cc View 8 chunks +78 lines, -43 lines 0 comments Download
M chromeos/network/network_ui_data.h View 6 chunks +3 lines, -47 lines 0 comments Download
M chromeos/network/network_ui_data.cc View 1 6 chunks +4 lines, -108 lines 0 comments Download
M chromeos/network/network_ui_data_unittest.cc View 2 chunks +0 lines, -84 lines 0 comments Download
M chromeos/network/policy_util.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chromeos/test/data/network/policy/shill_policy_on_unmanaged_ethernet_eap.json View 1 chunk +1 line, -1 line 0 comments Download
D chromeos/test/data/network/uidata_for_l2tpipsec_clientcert.json View 1 chunk +0 lines, -19 lines 0 comments Download
D chromeos/test/data/network/uidata_for_openvpn_clientcert.json View 1 chunk +0 lines, -19 lines 0 comments Download
D chromeos/test/data/network/uidata_for_wifi_clientcert.json View 1 chunk +0 lines, -13 lines 0 comments Download
D chromeos/test/data/network/uidata_for_wifi_clientref.json View 1 chunk +0 lines, -4 lines 0 comments Download
D chromeos/test/data/network/uidata_for_wifi_psk.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
pneubeck (no reviews)
After a one-day rampage, this is the CL that you were waiting for! Ok, nearly, ...
6 years, 5 months ago (2014-07-03 19:24:59 UTC) #1
stevenjb
Thanks a ton for doing this! (I was kind of hoping you might :) ) ...
6 years, 5 months ago (2014-07-07 19:34:06 UTC) #2
pneubeck (no reviews)
https://codereview.chromium.org/370623002/diff/50001/chrome/browser/chromeos/enrollment_dialog_view.cc File chrome/browser/chromeos/enrollment_dialog_view.cc (right): https://codereview.chromium.org/370623002/diff/50001/chrome/browser/chromeos/enrollment_dialog_view.cc#newcode303 chrome/browser/chromeos/enrollment_dialog_view.cc:303: return enrollment->Enroll(cert_config.pattern.enrollment_uri_list(), On 2014/07/07 19:34:05, stevenjb wrote: > Is ...
6 years, 5 months ago (2014-07-09 07:51:27 UTC) #3
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-09 07:51:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/370623002/90001
6 years, 5 months ago (2014-07-09 07:52:03 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 10:45:43 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 10:52:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/28583)
6 years, 5 months ago (2014-07-09 10:52:36 UTC) #8
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-09 13:06:12 UTC) #9
pneubeck (no reviews)
The CQ bit was unchecked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-09 13:07:12 UTC) #10
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-09 13:08:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/370623002/130001
6 years, 5 months ago (2014-07-09 13:09:12 UTC) #12
pneubeck (no reviews)
6 years, 5 months ago (2014-07-09 15:11:18 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 manually as r282038 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698