Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: chrome/browser/chromeos/enrollment_dialog_view.cc

Issue 370623002: Remove most of NetworkUIData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed yet-another unused function. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/net/onc_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/enrollment_dialog_view.cc
diff --git a/chrome/browser/chromeos/enrollment_dialog_view.cc b/chrome/browser/chromeos/enrollment_dialog_view.cc
index 405f6afd379fdb8730cd12a9d97f0922fb5ee19f..133652f7280ba2598e9c7b204bfc3ab877204071 100644
--- a/chrome/browser/chromeos/enrollment_dialog_view.cc
+++ b/chrome/browser/chromeos/enrollment_dialog_view.cc
@@ -6,10 +6,13 @@
#include "base/bind.h"
#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/chromeos/profiles/profile_helper.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_navigator.h"
+#include "chromeos/network/client_cert_util.h"
+#include "chromeos/network/managed_network_configuration_handler.h"
#include "chromeos/network/network_event_log.h"
#include "chromeos/network/network_state.h"
#include "chromeos/network/network_state_handler.h"
@@ -216,11 +219,6 @@ DialogEnrollmentDelegate::~DialogEnrollmentDelegate() {}
bool DialogEnrollmentDelegate::Enroll(const std::vector<std::string>& uri_list,
const base::Closure& post_action) {
- if (uri_list.empty()) {
- NET_LOG_EVENT("No enrollment URIs", network_name_);
- return false;
- }
-
// Keep the closure for later activation if we notice that
// a certificate has been added.
@@ -267,27 +265,42 @@ bool CreateDialog(const std::string& service_path,
NET_LOG_ERROR("Enrolling Unknown network", service_path);
return false;
}
+ Browser* browser = chrome::FindBrowserWithWindow(owning_window);
+ Profile* profile =
+ browser ? browser->profile() : ProfileManager::GetPrimaryUserProfile();
+ std::string username_hash = ProfileHelper::GetUserIdHashFromProfile(profile);
+
+ onc::ONCSource onc_source = onc::ONC_SOURCE_NONE;
+ const base::DictionaryValue* policy =
+ NetworkHandler::Get()
+ ->managed_network_configuration_handler()
+ ->FindPolicyByGUID(username_hash, network->guid(), &onc_source);
+
// We skip certificate patterns for device policy ONC so that an unmanaged
// user can't get to the place where a cert is presented for them
// involuntarily.
- if (network->ui_data().onc_source() == onc::ONC_SOURCE_DEVICE_POLICY)
+ if (!policy || onc_source == onc::ONC_SOURCE_DEVICE_POLICY)
return false;
- const CertificatePattern& certificate_pattern =
- network->ui_data().certificate_pattern();
- if (certificate_pattern.Empty()) {
- NET_LOG_EVENT("No certificate pattern found", service_path);
+ client_cert::ClientCertConfig cert_config;
+ OncToClientCertConfig(*policy, &cert_config);
+
+ if (cert_config.client_cert_type != onc::client_cert::kPattern)
+ return false;
+
+ if (cert_config.pattern.Empty())
+ NET_LOG_ERROR("Certificate pattern is empty", service_path);
+
+ if (cert_config.pattern.enrollment_uri_list().empty()) {
+ NET_LOG_EVENT("No enrollment URIs", service_path);
return false;
}
NET_LOG_USER("Enrolling", service_path);
- Browser* browser = chrome::FindBrowserWithWindow(owning_window);
- Profile* profile = browser ? browser->profile() :
- ProfileManager::GetPrimaryUserProfile();
DialogEnrollmentDelegate* enrollment =
new DialogEnrollmentDelegate(owning_window, network->name(), profile);
- return enrollment->Enroll(certificate_pattern.enrollment_uri_list(),
+ return enrollment->Enroll(cert_config.pattern.enrollment_uri_list(),
base::Bind(&EnrollmentComplete, service_path));
}
« no previous file with comments | « no previous file | chrome/browser/chromeos/net/onc_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698