Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Issue 370593002: Remove updateFirstLetter and firstLineBlock from RenderTable. (Closed)

Created:
6 years, 5 months ago by dsinclair
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove updateFirstLetter and firstLineBlock from RenderTable. These methods were added when first letter support was initially added in https://src.chromium.org/viewvc/blink?revision=5249&view=revision. Removing them causes no test failures, but there does not appear to be any tests that where added initially. BUG=391288 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178077

Patch Set 1 #

Patch Set 2 : Add layout test #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -12 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/first-letter-table.html View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/first-letter-table-expected.txt View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderTable.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderTable.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dsinclair
PTAL. I created a layout test locally that didn't seem to have any issues. (The ...
6 years, 5 months ago (2014-07-03 16:51:30 UTC) #1
esprehn
On 2014/07/03 at 16:51:30, dsinclair wrote: > PTAL. > > I created a layout test ...
6 years, 5 months ago (2014-07-06 09:18:16 UTC) #2
dsinclair
On 2014/07/06 09:18:16, esprehn wrote: > On 2014/07/03 at 16:51:30, dsinclair wrote: > > PTAL. ...
6 years, 5 months ago (2014-07-14 14:34:14 UTC) #3
Julien - ping for review
I don't think the test is testing what you expect as RenderTable::addChild will wrap any ...
6 years, 5 months ago (2014-07-14 15:44:14 UTC) #4
dsinclair
https://codereview.chromium.org/370593002/diff/40001/LayoutTests/fast/css/first-letter-table.html File LayoutTests/fast/css/first-letter-table.html (right): https://codereview.chromium.org/370593002/diff/40001/LayoutTests/fast/css/first-letter-table.html#newcode2 LayoutTests/fast/css/first-letter-table.html:2: On 2014/07/14 15:44:13, Julien Chaffraix - PST wrote: > ...
6 years, 5 months ago (2014-07-14 15:50:19 UTC) #5
dsinclair
The CQ bit was checked by dsinclair@chromium.org
6 years, 5 months ago (2014-07-14 15:53:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/370593002/80001
6 years, 5 months ago (2014-07-14 15:54:36 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 17:03:26 UTC) #8
Message was sent while issue was closed.
Change committed as 178077

Powered by Google App Engine
This is Rietveld 408576698