Remove updateFirstLetter and firstLineBlock from RenderTable.

Remove updateFirstLetter and firstLineBlock from RenderTable.

These methods were added when first letter support was initially added in
https://src.chromium.org/viewvc/blink?revision=5249&view=revision. Removing
them causes no test failures, but there does not appear to be any tests that
where added initially.

BUG=391288
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178077

[dsinclair, 2014-07-03 16:51:30]

PTAL.

I created a layout test locally that didn't seem to have any issues. (The a gets
bumped above the table and the first-letter has no effect.)

<style>
    #target { font-family: Ahem; font-size: 50px; background-color: green;
height: 50px; width: 50px; }
    #target:first-letter { color: red; }
</style>
<table id="target">
 a
 <tr><td>Test</td></tr>
</table>

[esprehn, 2014-07-06 09:18:16]

On 2014/07/03 at 16:51:30, dsinclair wrote:
> PTAL.
> 
> I created a layout test locally that didn't seem to have any issues. (The a
gets bumped above the table and the first-letter has no effect.)
> 
> <style>
>     #target { font-family: Ahem; font-size: 50px; background-color: green;
height: 50px; width: 50px; }
>     #target:first-letter { color: red; }
> </style>
> <table id="target">
>  a
>  <tr><td>Test</td></tr>
> </table>

You can't write a test like that, the parser will lift the "a" out of the table.
You want do appendChild() instead.

[dsinclair, 2014-07-14 14:34:14]

On 2014/07/06 09:18:16, esprehn wrote:
> On 2014/07/03 at 16:51:30, dsinclair wrote:
> > PTAL.
> > 
> > I created a layout test locally that didn't seem to have any issues. (The a
> gets bumped above the table and the first-letter has no effect.)
> > 
> > <style>
> >     #target { font-family: Ahem; font-size: 50px; background-color: green;
> height: 50px; width: 50px; }
> >     #target:first-letter { color: red; }
> > </style>
> > <table id="target">
> >  a
> >  <tr><td>Test</td></tr>
> > </table>
> 
> You can't write a test like that, the parser will lift the "a" out of the
table.
> You want do appendChild() instead.


Added a test file. PTAL.

[Julien - ping for review, 2014-07-14 15:44:14]

I don't think the test is testing what you expect as RenderTable::addChild will
wrap any text node into an anonymous row group, row and cell.

That said, I don't think there is a way to test what you want as <table>
shouldn't have text nodes as direct children so LGTM

https://codereview.chromium.org/370593002/diff/40001/LayoutTests/fast/css/fir...
File LayoutTests/fast/css/first-letter-table.html (right):

https://codereview.chromium.org/370593002/diff/40001/LayoutTests/fast/css/fir...
LayoutTests/fast/css/first-letter-table.html:2: 
Nit: Unneeded empty space.

https://codereview.chromium.org/370593002/diff/40001/LayoutTests/fast/css/fir...
LayoutTests/fast/css/first-letter-table.html:3: <script>
if (window.testRunner)
    testRunner.dumpAsText();

https://codereview.chromium.org/370593002/diff/40001/LayoutTests/fast/css/fir...
LayoutTests/fast/css/first-letter-table.html:27: <div>This test is successfully
if it does not crash.</div>
Let's add a description about what you are testing.

[dsinclair, 2014-07-14 15:50:19]

https://codereview.chromium.org/370593002/diff/40001/LayoutTests/fast/css/fir...
File LayoutTests/fast/css/first-letter-table.html (right):

https://codereview.chromium.org/370593002/diff/40001/LayoutTests/fast/css/fir...
LayoutTests/fast/css/first-letter-table.html:2: 
On 2014/07/14 15:44:13, Julien Chaffraix - PST wrote:
> Nit: Unneeded empty space.

Done.

https://codereview.chromium.org/370593002/diff/40001/LayoutTests/fast/css/fir...
LayoutTests/fast/css/first-letter-table.html:3: <script>
On 2014/07/14 15:44:14, Julien Chaffraix - PST wrote:
> if (window.testRunner)
>     testRunner.dumpAsText();

Done.

https://codereview.chromium.org/370593002/diff/40001/LayoutTests/fast/css/fir...
LayoutTests/fast/css/first-letter-table.html:27: <div>This test is successfully
if it does not crash.</div>
On 2014/07/14 15:44:14, Julien Chaffraix - PST wrote:
> Let's add a description about what you are testing.

Better?

[dsinclair, 2014-07-14 15:53:46]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2014-07-14 15:54:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dsinclair@chromium.org/370593002/80001

[commit-bot: I haz the power, 2014-07-14 17:03:26]

Change committed as 178077