LayoutTests/fast/css/first-letter-table.html - Issue 370593002: Remove updateFirstLetter and firstLineBlock from RenderTable.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/first-letter-table.html

Issue 370593002: Remove updateFirstLetter and firstLineBlock from RenderTable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!doctype html>

	2
	Julien - ping for review 2014/07/14 15:44:13 Nit: Unneeded empty space. Nit: Unneeded empty space. dsinclair 2014/07/14 15:50:18 Done. Show quoted text On 2014/07/14 15:44:13, Julien Chaffraix - PST wrote: > Nit: Unneeded empty space. Done.
	3 <script>
	Julien - ping for review 2014/07/14 15:44:14 if (window.testRunner) testRunner.dumpAsText() if (window.testRunner) testRunner.dumpAsText(); dsinclair 2014/07/14 15:50:18 Done. Show quoted text On 2014/07/14 15:44:14, Julien Chaffraix - PST wrote: > if (window.testRunner) > testRunner.dumpAsText(); Done.
	4 function makeChild()

	5 {

	6 var child = document.createElement('div');

	7 child.textContent = 'my text content';

	8 return child;

	9 }

	10

	11 function runTest()

	12 {

	13 document.querySelector('table').appendChild(makeChild());

	14 document.querySelector('tbody').appendChild(makeChild());

	15 document.querySelector('tr').appendChild(makeChild());

	16 document.querySelector('td').appendChild(makeChild());

	17 }

	18 onload = runTest;

	19 </script>

	20 <style>

	21 #target {

	22 background-color: green;

	23 }

	24 #target:first-letter, #target div:first-letter { color: red; }

	25 </style>

	26

	27 <div>This test is successfully if it does not crash.</div>
	Julien - ping for review 2014/07/14 15:44:14 Let's add a description about what you are testing Let's add a description about what you are testing. dsinclair 2014/07/14 15:50:18 Better? Show quoted text On 2014/07/14 15:44:14, Julien Chaffraix - PST wrote: > Let's add a description about what you are testing. Better?
	28

	29 <table id="target">

	30 a

	31 <tr><td>Test</td></tr>

	32 </table>

OLD	NEW

« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/rendering/RenderTable.h » ('j') | no next file with comments »