Issue 370573003: Hydrogenized KeyedLoadGeneric stub: Fix FieldIndex::GetLoadByFieldIndex()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 370573003: Hydrogenized KeyedLoadGeneric stub: Fix FieldIndex::GetLoadByFieldIndex() (Closed)

Created:
6 years, 5 months ago by Jakob Kummerow

Modified:
6 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Hydrogenized KeyedLoadGeneric stub: Fix FieldIndex::GetLoadByFieldIndex() R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22238

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -16 lines)			Patch
	M	src/field-index.h	View		5 chunks	+8 lines, -15 lines	0 comments	Download
	M	src/field-index-inl.h	View		2 chunks	+27 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

PTAL. This mostly adds comments, except for the index correction in FieldIndex::GetLoadByFieldIndex().

6 years, 5 months ago (2014-07-03 16:28:13 UTC) #1

Jakob Kummerow

6 years, 5 months ago (2014-07-07 11:35:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22238 (presubmit successful).