Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 370563002: Remove PrivateScriptInterface (Closed)

Created:
6 years, 5 months ago by haraken
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Remove PrivateScriptInterface We changed the design of Blink-in-JS, and we no longer need an PrivateScriptInterface, which can support only static methods. BUG=341031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177478

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -406 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/code_generator_v8.py View 3 chunks +1 line, -9 lines 0 comments Download
M Source/bindings/scripts/scripts.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D Source/bindings/scripts/v8_private_script_interface.py View 1 chunk +0 lines, -83 lines 0 comments Download
D Source/bindings/templates/private_script_interface.h View 1 chunk +0 lines, -28 lines 0 comments Download
D Source/bindings/templates/private_script_interface.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
M Source/bindings/templates/templates.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D Source/bindings/tests/idls/TestPrivateScriptInterface.idl View 1 chunk +0 lines, -15 lines 0 comments Download
D Source/bindings/tests/results/V8TestPrivateScriptInterface.h View 1 chunk +0 lines, -29 lines 0 comments Download
D Source/bindings/tests/results/V8TestPrivateScriptInterface.cpp View 1 chunk +0 lines, -178 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
haraken
PTAL
6 years, 5 months ago (2014-07-03 11:47:15 UTC) #1
dcarney
lgtm
6 years, 5 months ago (2014-07-03 12:13:00 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 5 months ago (2014-07-03 12:14:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/370563002/20001
6 years, 5 months ago (2014-07-03 12:14:41 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-03 13:18:53 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 13:50:34 UTC) #6
Message was sent while issue was closed.
Change committed as 177478

Powered by Google App Engine
This is Rietveld 408576698