Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: Source/bindings/scripts/code_generator_v8.py

Issue 370563002: Remove PrivateScriptInterface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/IDLExtendedAttributes.txt ('k') | Source/bindings/scripts/scripts.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.py
diff --git a/Source/bindings/scripts/code_generator_v8.py b/Source/bindings/scripts/code_generator_v8.py
index e7233ebc4f5c96feafb9ad4febd31446af66b2f9..f7af610ccd9ab3b1a92911d9329d2b8a550d43e8 100644
--- a/Source/bindings/scripts/code_generator_v8.py
+++ b/Source/bindings/scripts/code_generator_v8.py
@@ -75,7 +75,6 @@ from idl_types import IdlType
import v8_callback_interface
from v8_globals import includes, interfaces
import v8_interface
-import v8_private_script_interface
import v8_types
from v8_utilities import capitalize, cpp_name, conditional_string, v8_class_name
@@ -131,12 +130,6 @@ class CodeGeneratorV8(object):
header_template_filename = 'callback_interface.h'
cpp_template_filename = 'callback_interface.cpp'
interface_context = v8_callback_interface.callback_interface_context
- elif 'PrivateScriptInterface' in interface.extended_attributes:
- # Currently private scripts don't have dependencies. Once private scripts have dependencies,
- # we should add them to interface_info.
- header_template_filename = 'private_script_interface.h'
- cpp_template_filename = 'private_script_interface.cpp'
- interface_context = v8_private_script_interface.private_script_interface_context
else:
header_template_filename = 'interface.h'
cpp_template_filename = 'interface.cpp'
@@ -150,8 +143,7 @@ class CodeGeneratorV8(object):
# Add includes for interface itself and any dependencies
interface_info = self.interfaces_info[interface_name]
- if 'PrivateScriptInterface' not in interface.extended_attributes:
- template_context['header_includes'].add(interface_info['include_path'])
+ template_context['header_includes'].add(interface_info['include_path'])
template_context['header_includes'] = sorted(template_context['header_includes'])
includes.update(interface_info.get('dependencies_include_paths', []))
template_context['cpp_includes'] = sorted(includes)
« no previous file with comments | « Source/bindings/IDLExtendedAttributes.txt ('k') | Source/bindings/scripts/scripts.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698