Issue 370533003: Change AndroidHistoryProviderService to use CancelableTaskTracker (6/6)

Issue 370533003: Change AndroidHistoryProviderService to use CancelableTaskTracker (6/6) (Closed)

Created:
6 years, 5 months ago by sdefresne

Modified:
6 years, 5 months ago

Reviewers:
Miguel Garcia, blundell

CC:
chromium-reviews, browser-components-watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@cancelable_task_tracker.6

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change AndroidHistoryProviderService to use CancelableTaskTracker (6/6) Port DeleteHistoryAndBookmarks, DeleteHistory and DeleteSearchTerms to use base::CancelableTaskTracker instead of CancelableRequestConsumer. BUG=371818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284099

Patch Set 1 #

Patch Set 2 : clang-format #

Patch Set 3 : Document methods #

Patch Set 4 : Fix unit tests #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -118 lines)			Patch
M	chrome/browser/android/provider/chrome_browser_provider.cc	View	1 2	3 chunks	+21 lines, -22 lines	0 comments	Download
M	chrome/browser/history/android/android_history_provider_service.h	View	1 2	4 chunks	+19 lines, -20 lines	0 comments	Download
M	chrome/browser/history/android/android_history_provider_service.cc	View	1	3 chunks	+45 lines, -30 lines	0 comments	Download
M	chrome/browser/history/android/android_history_provider_service_unittest.cc	View	1 2 3	3 chunks	+10 lines, -8 lines	0 comments	Download
M	chrome/browser/history/history_backend.h	View	1 2	2 chunks	+18 lines, -8 lines	0 comments	Download
M	chrome/browser/history/history_backend_android.cc	View	1	2 chunks	+13 lines, -30 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sdefresne

Could you please take a look? This is the sixth of a series of seven ...

6 years, 5 months ago (2014-07-03 17:20:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/370533003/60001

6 years, 5 months ago (2014-07-18 13:00:33 UTC) #6

Message was sent while issue was closed.

Change committed as 284099

Expand Messages | Collapse Messages