chrome/browser/history/history_backend.h - Issue 370533003: Change AndroidHistoryProviderService to use CancelableTaskTracker (6/6)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_backend.h

Issue 370533003: Change AndroidHistoryProviderService to use CancelableTaskTracker (6/6) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cancelable_task_tracker.6

Patch Set: Fix unit tests Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/android/android_history_provider_service_unittest.cc ('k') | chrome/browser/history/history_backend_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/history_backend.h

diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h

index 46273e2dff9cad745b382c8265809602c905a2d2..41ff49f9e2052aee21600914a14d1468e7fda879 100644

--- a/chrome/browser/history/history_backend.h

+++ b/chrome/browser/history/history_backend.h

@@ -311,14 +311,19 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,

const std::string& selection,

const std::vector<base::string16>& selection_args);

- void DeleteHistoryAndBookmarks(

- scoped_refptr<DeleteRequest> request,

+ // Deletes the specified rows and returns the number of rows deleted.

+ //

+ // |selection| is the SQL WHERE clause without 'WHERE'.

+ // |selection_args| is the arguments for the WHERE clause.

+ //

+ // If |selection| is empty all history and bookmarks are deleted.

+ int DeleteHistoryAndBookmarks(

const std::string& selection,

const std::vector<base::string16>& selection_args);

- void DeleteHistory(scoped_refptr<DeleteRequest> request,

- const std::string& selection,

- const std::vector<base::string16>& selection_args);

+ // Deletes the matched history and returns the number of rows deleted.

+ int DeleteHistory(const std::string& selection,

+ const std::vector<base::string16>& selection_args);

// Statement ----------------------------------------------------------------

// Move the statement's current position.

@@ -342,9 +347,14 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,

const std::string& selection,

const std::vector<base::string16> selection_args);

- void DeleteSearchTerms(scoped_refptr<DeleteRequest> request,

- const std::string& selection,

- const std::vector<base::string16> selection_args);

+ // Deletes the matched rows and returns the number of deleted rows.

+ //

+ // |selection| is the SQL WHERE clause without 'WHERE'.

+ // |selection_args| is the arguments for WHERE clause.

+ //

+ // If |selection| is empty all search terms will be deleted.

+ int DeleteSearchTerms(const std::string& selection,

+ const std::vector<base::string16> selection_args);

// Returns the result of the given query.