Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 370523002: Translate: Implement reset the denial state on chrome://translate-internals (Closed)

Created:
6 years, 5 months ago by hajimehoshi
Modified:
6 years, 5 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Translate: Implement reset the denial state on chrome://translate-internals Now the bubble is not shown when the user denies the translation too often, and this states are saved at prefs. This CL enables uses to see and reset these prefs at chrome://translate-internals. BUG=379035 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281701

Patch Set 1 #

Patch Set 2 : Kenji's suggestion #

Total comments: 2

Patch Set 3 : estade's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -11 lines) Patch
M chrome/browser/resources/translate_internals/prefs.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/translate_internals/translate_internals.css View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/resources/translate_internals/translate_internals.js View 1 2 3 chunks +24 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_prefs.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_prefs.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hajimehoshi
PTAL estade: chrome/browser/{resources|ui} toyoshim: components/translate
6 years, 5 months ago (2014-07-03 06:45:52 UTC) #1
Takashi Toyoshima
lgtm
6 years, 5 months ago (2014-07-04 09:40:22 UTC) #2
Evan Stade
lgtm https://codereview.chromium.org/370523002/diff/20001/chrome/browser/resources/translate_internals/translate_internals.js File chrome/browser/resources/translate_internals/translate_internals.js (right): https://codereview.chromium.org/370523002/diff/20001/chrome/browser/resources/translate_internals/translate_internals.js#newcode220 chrome/browser/resources/translate_internals/translate_internals.js:220: p.appendChild(createDismissingButton(function() { I think if you do: p.appendChild(createDismissingButton( ...
6 years, 5 months ago (2014-07-07 16:12:40 UTC) #3
hajimehoshi
Thank you! https://codereview.chromium.org/370523002/diff/20001/chrome/browser/resources/translate_internals/translate_internals.js File chrome/browser/resources/translate_internals/translate_internals.js (right): https://codereview.chromium.org/370523002/diff/20001/chrome/browser/resources/translate_internals/translate_internals.js#newcode220 chrome/browser/resources/translate_internals/translate_internals.js:220: p.appendChild(createDismissingButton(function() { On 2014/07/07 16:12:39, Evan Stade ...
6 years, 5 months ago (2014-07-08 05:33:47 UTC) #4
hajimehoshi
The CQ bit was checked by hajimehoshi@chromium.org
6 years, 5 months ago (2014-07-08 05:33:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/370523002/40001
6 years, 5 months ago (2014-07-08 05:34:24 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 09:24:23 UTC) #7
Message was sent while issue was closed.
Change committed as 281701

Powered by Google App Engine
This is Rietveld 408576698