chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc - Issue 370523002: Translate: Implement reset the denial state on chrome://translate-internals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

Issue 370523002: Translate: Implement reset the denial state on chrome://translate-internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: estade's review Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/translate_internals/translate_internals.js ('k') | components/translate/core/browser/translate_prefs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

diff --git a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

index ff411766b1e16879c7215e7603172478df943666..7b1fc54c2c42eaa40aa37f446bc3e73232c11931 100644

--- a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

+++ b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

@@ -155,6 +155,8 @@ void TranslateInternalsHandler::OnRemovePrefItem(const base::ListValue* args) {

if (!args->GetString(2, &to))

return;

translate_prefs->RemoveLanguagePairFromWhitelist(from, to);

+ } else if (pref_name == "too_often_denied") {

+ translate_prefs->ResetDenialState();

} else {

return;

}

@@ -191,6 +193,8 @@ void TranslateInternalsHandler::SendPrefsToJs() {

keys.push_back(TranslatePrefs::kPrefTranslateWhitelists);

keys.push_back(TranslatePrefs::kPrefTranslateDeniedCount);

keys.push_back(TranslatePrefs::kPrefTranslateAcceptedCount);

+ keys.push_back(TranslatePrefs::kPrefTranslateLastDeniedTime);

+ keys.push_back(TranslatePrefs::kPrefTranslateTooOftenDenied);

for (std::vector<std::string>::const_iterator it = keys.begin();

it != keys.end(); ++it) {