Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 370463002: Remove vertical/horizontal metrics selection. (Closed)

Created:
6 years, 5 months ago by bungeman-skia
Modified:
6 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove vertical/horizontal metrics selection. Committed: https://skia.googlesource.com/skia/+/410780677af260e32948b02c0725ef6ad761260c

Patch Set 1 #

Patch Set 2 : Fix Mac. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -215 lines) Patch
M src/core/SkScalerContext.h View 2 chunks +6 lines, -5 lines 0 comments Download
M src/core/SkScalerContext.cpp View 2 chunks +4 lines, -17 lines 0 comments Download
M src/fonts/SkGScalerContext.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 5 chunks +26 lines, -56 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 1 2 chunks +20 lines, -25 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 4 chunks +36 lines, -68 lines 0 comments Download
M src/ports/SkScalerContext_win_dw.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ports/SkScalerContext_win_dw.cpp View 2 chunks +15 lines, -35 lines 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
bungeman-skia
6 years, 5 months ago (2014-07-07 14:52:14 UTC) #1
reed1
lgtm
6 years, 5 months ago (2014-07-07 14:58:58 UTC) #2
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 5 months ago (2014-07-07 15:01:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/370463002/20001
6 years, 5 months ago (2014-07-07 15:01:34 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 15:16:41 UTC) #5
Message was sent while issue was closed.
Change committed as 410780677af260e32948b02c0725ef6ad761260c

Powered by Google App Engine
This is Rietveld 408576698