Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: src/core/SkScalerContext.h

Issue 370463002: Remove vertical/horizontal metrics selection. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix Mac. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkScalerContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkScalerContext.h
diff --git a/src/core/SkScalerContext.h b/src/core/SkScalerContext.h
index af83685eb69dc96c782dc5eb13ecf133ad000cfd..be5d3b555eb51ebae1681e69e126db22c8ad910c 100644
--- a/src/core/SkScalerContext.h
+++ b/src/core/SkScalerContext.h
@@ -160,6 +160,10 @@ public:
return SkToBool(fRec.fFlags & kSubpixelPositioning_Flag);
}
+ bool isVertical() const {
+ return SkToBool(fRec.fFlags & kVertical_Flag);
+ }
+
// remember our glyph offset/base
void setBaseGlyphCount(unsigned baseGlyphCount) {
fBaseGlyphCount = baseGlyphCount;
@@ -245,11 +249,8 @@ protected:
*/
virtual void generatePath(const SkGlyph& glyph, SkPath* path) = 0;
- /** Retrieves font metrics.
- * TODO: there is now a vertical bit, no need for two parameters.
- */
- virtual void generateFontMetrics(SkPaint::FontMetrics* mX,
- SkPaint::FontMetrics* mY) = 0;
+ /** Retrieves font metrics. */
+ virtual void generateFontMetrics(SkPaint::FontMetrics*) = 0;
/** Returns the number of glyphs in the font. */
virtual unsigned generateGlyphCount() = 0;
« no previous file with comments | « no previous file | src/core/SkScalerContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698