Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 370073002: Use type cast macro for AnimatableLengthPoint|3D instead of manual toFoo() (Closed)

Created:
6 years, 5 months ago by gyuyoung-inactive
Modified:
6 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, aboxhall, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, dmazzoni, apavlov+blink_chromium.org, rwlbuis, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use type cast macro for AnimatableLengthPoint|3D instead of manual toFoo() Type casting generation macro supports more plenty toFoo() function with unnecessary type cast checking. Additionally this cl clean up static_cast<CSS|HTML|AXFoo> using toFoo(). BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177624

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -21 lines) Patch
M Source/core/accessibility/AXSpinButton.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AXTable.cpp View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLengthPoint.h View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLengthPoint3D.h View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/animation/interpolation/LegacyStyleInterpolation.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/BasicShapeFunctions.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
gyuyoung-inactive
PTAL
6 years, 5 months ago (2014-07-05 04:49:59 UTC) #1
tkent
lgtm
6 years, 5 months ago (2014-07-07 23:31:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/370073002/30001
6 years, 5 months ago (2014-07-07 23:31:48 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 23:31:54 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Source/core/animation/AnimatableLengthPoint.h: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
6 years, 5 months ago (2014-07-07 23:31:55 UTC) #5
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-08 00:36:22 UTC) #6
gyuyoung-inactive
On 2014/07/07 23:31:55, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 5 months ago (2014-07-08 00:37:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/370073002/50001
6 years, 5 months ago (2014-07-08 00:37:23 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 01:41:29 UTC) #9
Message was sent while issue was closed.
Change committed as 177624

Powered by Google App Engine
This is Rietveld 408576698