Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Side by Side Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 370073002: Use type cast macro for AnimatableLengthPoint|3D instead of manual toFoo() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/BasicShapeFunctions.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 3428 matching lines...) Expand 10 before | Expand all | Expand 10 after
3439 3439
3440 // At least template-areas strings must be defined. 3440 // At least template-areas strings must be defined.
3441 if (!m_valueList->current()) 3441 if (!m_valueList->current())
3442 return false; 3442 return false;
3443 3443
3444 while (m_valueList->current()) { 3444 while (m_valueList->current()) {
3445 // Handle leading <custom-ident>*. 3445 // Handle leading <custom-ident>*.
3446 if (m_valueList->current()->unit == CSSParserValue::ValueList) { 3446 if (m_valueList->current()->unit == CSSParserValue::ValueList) {
3447 if (trailingIdentWasAdded) { 3447 if (trailingIdentWasAdded) {
3448 // A row's trailing ident must be concatenated with the next row 's leading one. 3448 // A row's trailing ident must be concatenated with the next row 's leading one.
3449 parseGridLineNames(*m_valueList, *templateRows, static_cast<CSSG ridLineNamesValue*>(templateRows->item(templateRows->length() - 1))); 3449 parseGridLineNames(*m_valueList, *templateRows, toCSSGridLineNam esValue(templateRows->item(templateRows->length() - 1)));
3450 } else { 3450 } else {
3451 parseGridLineNames(*m_valueList, *templateRows); 3451 parseGridLineNames(*m_valueList, *templateRows);
3452 } 3452 }
3453 } 3453 }
3454 3454
3455 // Handle a template-area's row. 3455 // Handle a template-area's row.
3456 if (!parseGridTemplateAreasRow(gridAreaMap, rowCount, columnCount)) 3456 if (!parseGridTemplateAreasRow(gridAreaMap, rowCount, columnCount))
3457 return false; 3457 return false;
3458 ++rowCount; 3458 ++rowCount;
3459 3459
(...skipping 5048 matching lines...) Expand 10 before | Expand all | Expand 10 after
8508 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueFill)); 8508 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueFill));
8509 if (!seenStroke) 8509 if (!seenStroke)
8510 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueStroke) ); 8510 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueStroke) );
8511 if (!seenMarkers) 8511 if (!seenMarkers)
8512 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueMarkers )); 8512 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueMarkers ));
8513 8513
8514 return parsedValues.release(); 8514 return parsedValues.release();
8515 } 8515 }
8516 8516
8517 } // namespace WebCore 8517 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/BasicShapeFunctions.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698