Use the correct thread to access g_browser_process.

Use the correct thread to access g_browser_process.

Since g_browser_process can only be accessed by ui thread, and GoogleUpdateSettings::GetCollectStatsConsent should be called by FILE thread, it doesn't make sense to put them in the same function, which is executed through posttask on FILE thread. 

Schedules only GoogleUpdateSettings::GetCollectStatsConsent on FILE thread, and does everything else on IO thread in ShowForReal()

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281865

[yao, 2014-07-07 15:38:38]

PTAL, thanks!

[jwd, 2014-07-07 19:57:24]

LGTM with nits

https://codereview.chromium.org/369933002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/session_crashed_bubble_view.cc (right):

https://codereview.chromium.org/369933002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/session_crashed_bubble_view.cc:139: // Determine whether
or not uma opt-in option should be offered. It is offered
nit: whether or not THE uma opt-in..

https://codereview.chromium.org/369933002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/session_crashed_bubble_view.h (right):

https://codereview.chromium.org/369933002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/session_crashed_bubble_view.h:55: // indicating whether
the user has already opted-in to UMA. It will called by
"It will BE called by..."

[yao, 2014-07-07 20:24:48]

+msw for owner's review, Thanks

https://codereview.chromium.org/369933002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/session_crashed_bubble_view.cc (right):

https://codereview.chromium.org/369933002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/session_crashed_bubble_view.cc:139: // Determine whether
or not uma opt-in option should be offered. It is offered
On 2014/07/07 19:57:24, Jesse Doherty wrote:
> nit: whether or not THE uma opt-in..

Done.

https://codereview.chromium.org/369933002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/session_crashed_bubble_view.h (right):

https://codereview.chromium.org/369933002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/session_crashed_bubble_view.h:55: // indicating whether
the user has already opted-in to UMA. It will called by
On 2014/07/07 19:57:24, Jesse Doherty wrote:
> "It will BE called by..."

Done.

[msw, 2014-07-07 22:59:08]

lgtm, please fill out BUG= if there's a relevant issue.

[yao, 2014-07-08 14:09:02]

The CQ bit was checked by yiyaoliu@chromium.org

[commit-bot: I haz the power, 2014-07-08 14:09:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yiyaoliu@chromium.org/369933002/50001

[yao, 2014-07-08 15:44:04]

The CQ bit was unchecked by yiyaoliu@chromium.org

[yao, 2014-07-08 17:50:15]

The CQ bit was checked by yiyaoliu@chromium.org

[commit-bot: I haz the power, 2014-07-08 17:51:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yiyaoliu@chromium.org/369933002/90001

[commit-bot: I haz the power, 2014-07-08 21:56:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)

[commit-bot: I haz the power, 2014-07-08 23:09:42]

Change committed as 281865