Use the correct thread to access g_browser_process.

chrome/browser/ui/views/session_crashed_bubble_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/session_crashed_bubble_view.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 47 matching lines @@
 
 // The color of the text and background of the sub panel to offer UMA optin.
 // These values match the BookmarkSyncPromoView colors.
 const SkColor kBackgroundColor = SkColorSetRGB(245, 245, 245);
 const SkColor kTextColor = SkColorSetRGB(102, 102, 102);
 
 // The Finch study name and group name that enables session crashed bubble UI.
 const char kEnableBubbleUIFinchName[] = "EnableSessionCrashedBubbleUI";
 const char kEnableBubbleUIGroupEnabled[] = "Enabled";
 
-bool ShouldOfferMetricsReporting() {
-// Stats collection only applies to Google Chrome builds.
-#if defined(GOOGLE_CHROME_BUILD)
-  // Only show metrics reporting option if user didn't already consent to it.
-  if (GoogleUpdateSettings::GetCollectStatsConsent())
-    return false;
-  return g_browser_process->local_state()->FindPreference(
-      prefs::kMetricsReportingEnabled)->IsUserModifiable();
-#else
-  return false;
-#endif  // defined(GOOGLE_CHROME_BUILD)
-}
-
 // Whether or not the bubble UI should be used.
 bool IsBubbleUIEnabled() {
   const base::CommandLine& command_line = *CommandLine::ForCurrentProcess();
   if (command_line.HasSwitch(switches::kDisableSessionCrashedBubble))
     return false;
   if (command_line.HasSwitch(switches::kEnableSessionCrashedBubble))
     return true;
   const std::string group_name = base::FieldTrialList::FindFullName(
       kEnableBubbleUIFinchName);
   return group_name == kEnableBubbleUIGroupEnabled;
@@ skipping 31 matching lines @@
 // static
 void SessionCrashedBubbleView::Show(Browser* browser) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   if (browser->profile()->IsOffTheRecord())
     return;
 
   // Observes browser removal event and will be deallocated in ShowForReal.
   scoped_ptr<BrowserRemovalObserver> browser_observer(
       new BrowserRemovalObserver(browser));
 
+// Stats collection only applies to Google Chrome builds.
+#if defined(GOOGLE_CHROME_BUILD)
   // Schedule a task to run ShouldOfferMetricsReporting() on FILE thread, since
   // GoogleUpdateSettings::GetCollectStatsConsent() does IO. Then, call
   // SessionCrashedBubbleView::ShowForReal with the result.
   content::BrowserThread::PostTaskAndReplyWithResult(
       content::BrowserThread::FILE,
       FROM_HERE,
-      base::Bind(&ShouldOfferMetricsReporting),
+      base::Bind(&GoogleUpdateSettings::GetCollectStatsConsent),
       base::Bind(&SessionCrashedBubbleView::ShowForReal,
                  base::Passed(&browser_observer)));
+#else
+  SessionCrashedBubbleView::ShowForReal(browser_observer, false);
+#endif  // defined(GOOGLE_CHROME_BUILD)
 }
 
 // static
 void SessionCrashedBubbleView::ShowForReal(
     scoped_ptr<BrowserRemovalObserver> browser_observer,
-    bool offer_uma_optin) {
+    bool uma_opted_in_already) {
+  // Determine whether or not uma opt-in option should be offered. It is offered

[jwd, 2014/07/07 19:57:24]

nit: whether or not THE uma opt-in..

[yao, 2014/07/07 20:24:48]

Done.

+  // only when it is a Google chrome build, user hasn't opted in yet, and the
+  // preference is modifiable by the user.
+  bool offer_uma_optin = false;
+
+#if defined(GOOGLE_CHROME_BUILD)
+  if (!uma_opted_in_already)
+    offer_uma_optin = g_browser_process->local_state()->FindPreference(
+        prefs::kMetricsReportingEnabled)->IsUserModifiable();
+#endif  // defined(GOOGLE_CHROME_BUILD)
+
   Browser* browser = browser_observer->browser();
 
   if (!browser)
     return;
 
   views::View* anchor_view =
       BrowserView::GetBrowserViewForBrowser(browser)->toolbar()->app_menu();
   content::WebContents* web_contents =
       browser->tab_strip_model()->GetActiveWebContents();
 
@@ skipping 235 matching lines @@
   GetWidget()->Close();
 }
 
 bool ShowSessionCrashedBubble(Browser* browser) {
   if (IsBubbleUIEnabled()) {
     SessionCrashedBubbleView::Show(browser);
     return true;
   }
   return false;
 }