Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 369843002: Fix deopt reason printing to print stub failure reason with --trace-stub-failures --code-comments (Closed)

Created:
6 years, 5 months ago by Jakob Kummerow
Modified:
6 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix deopt reason printing to print stub failure reason with --trace-stub-failures --code-comments R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22193

Patch Set 1 #

Patch Set 2 : extracted readable is_hydrogen_stub() predicate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/deoptimizer.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/objects.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
6 years, 5 months ago (2014-07-03 08:52:58 UTC) #1
Jarin
lgtm
6 years, 5 months ago (2014-07-03 11:31:58 UTC) #2
Jakob Kummerow
6 years, 5 months ago (2014-07-03 11:47:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22193 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698