Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Side by Side Diff: src/objects-inl.h

Issue 369843002: Fix deopt reason printing to print stub failure reason with --trace-stub-failures --code-comments (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: extracted readable is_hydrogen_stub() predicate Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 4553 matching lines...) Expand 10 before | Expand all | Expand 10 after
4564 WRITE_INT_FIELD(this, kKindSpecificFlags2Offset, value); 4564 WRITE_INT_FIELD(this, kKindSpecificFlags2Offset, value);
4565 } 4565 }
4566 4566
4567 4567
4568 inline bool Code::is_crankshafted() { 4568 inline bool Code::is_crankshafted() {
4569 return IsCrankshaftedField::decode( 4569 return IsCrankshaftedField::decode(
4570 READ_UINT32_FIELD(this, kKindSpecificFlags2Offset)); 4570 READ_UINT32_FIELD(this, kKindSpecificFlags2Offset));
4571 } 4571 }
4572 4572
4573 4573
4574 inline bool Code::is_hydrogen_stub() {
4575 return is_crankshafted() && kind() != OPTIMIZED_FUNCTION;
4576 }
4577
4578
4574 inline void Code::set_is_crankshafted(bool value) { 4579 inline void Code::set_is_crankshafted(bool value) {
4575 int previous = READ_UINT32_FIELD(this, kKindSpecificFlags2Offset); 4580 int previous = READ_UINT32_FIELD(this, kKindSpecificFlags2Offset);
4576 int updated = IsCrankshaftedField::update(previous, value); 4581 int updated = IsCrankshaftedField::update(previous, value);
4577 WRITE_UINT32_FIELD(this, kKindSpecificFlags2Offset, updated); 4582 WRITE_UINT32_FIELD(this, kKindSpecificFlags2Offset, updated);
4578 } 4583 }
4579 4584
4580 4585
4581 int Code::major_key() { 4586 int Code::major_key() {
4582 ASSERT(has_major_key()); 4587 ASSERT(has_major_key());
4583 return StubMajorKeyField::decode( 4588 return StubMajorKeyField::decode(
(...skipping 2474 matching lines...) Expand 10 before | Expand all | Expand 10 after
7058 #undef READ_SHORT_FIELD 7063 #undef READ_SHORT_FIELD
7059 #undef WRITE_SHORT_FIELD 7064 #undef WRITE_SHORT_FIELD
7060 #undef READ_BYTE_FIELD 7065 #undef READ_BYTE_FIELD
7061 #undef WRITE_BYTE_FIELD 7066 #undef WRITE_BYTE_FIELD
7062 #undef NOBARRIER_READ_BYTE_FIELD 7067 #undef NOBARRIER_READ_BYTE_FIELD
7063 #undef NOBARRIER_WRITE_BYTE_FIELD 7068 #undef NOBARRIER_WRITE_BYTE_FIELD
7064 7069
7065 } } // namespace v8::internal 7070 } } // namespace v8::internal
7066 7071
7067 #endif // V8_OBJECTS_INL_H_ 7072 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698