Remember user decisions on invalid certificates behind a flag

chrome/browser/about_flags.cc

Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 180cc403c8157318dc2294b4b5b27559d973a9d3..03c7d256d5d8ffcdaab0d454950aa28a8b88caad 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -491,6 +491,27 @@ const Experiment::Choice kEnableSettingsWindowChoices[] = {
     ::switches::kDisableSettingsWindow, "" },
 };
 
+// Note that the value is specified in seconds (where 0 is equivalent to
+// disabled).
+const Experiment::Choice kRememberCertificateErrorDecisionsChoices[] = {
+  { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+  { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
+    switches::kRememberCertErrorDecisions,

[felt, 2014/07/07 22:26:39]

FYI: FieldTrials doesn't currently support flag=value flags, so you'll need to
use a different flag for each one when you set up a Field Trial.

[jww, 2014/07/08 17:35:41]

Isn't it simpler than that? In my previous experiment, I didn't even use flags
in the field trial portion, and I plan on the same basic implementation here.
Basically, have a field trial bucket for each flag, and check if the user is in
the bucket *or* if they've overriden the choice with a flag.

[felt, 2014/07/08 17:52:48]

If you want to track forcing flags, I believe you need to have a different flag
for each condition:
https://sites.google.com/a/google.com/chrome-data/finch-experiments/guide-for...

[jww, 2014/07/08 23:49:01]

Got it. I've switched to pure flags style.

+    "0" },
+  { IDS_REMEMBER_CERTIFICATE_ERROR_DECISION_CHOICE_ONE_DAY,
+    switches::kRememberCertErrorDecisions,
+    "86400" },
+  { IDS_REMEMBER_CERTIFICATE_ERROR_DECISION_CHOICE_THREE_DAYS,
+    switches::kRememberCertErrorDecisions,
+    "259200" },
+  { IDS_REMEMBER_CERTIFICATE_ERROR_DECISION_CHOICE_ONE_WEEK,
+    switches::kRememberCertErrorDecisions,
+    "604800" },
+  { IDS_REMEMBER_CERTIFICATE_ERROR_DECISION_CHOICE_ONE_MONTH,
+    switches::kRememberCertErrorDecisions,
+    "2592000" },
+};
+
 // RECORDING USER METRICS FOR FLAGS:
 // -----------------------------------------------------------------------------
 // The first line of the experiment is the internal name. If you'd like to
@@ -1955,6 +1976,13 @@ const Experiment kExperiments[] = {
     SINGLE_VALUE_TYPE(chromeos::switches::kEnableOkGoogleVoiceSearch)
   },
 #endif
+  {
+    "remember-cert-error-decisions",
+    IDS_FLAGS_REMEMBER_CERTIFICATE_ERROR_DECISIONS_NAME,
+    IDS_FLAGS_REMEMBER_CERTIFICATE_ERROR_DECISIONS_DESCRIPTION,
+    kOsAll,
+    MULTI_VALUE_TYPE(kRememberCertificateErrorDecisionsChoices)
+  },
 };
 
 const Experiment* experiments = kExperiments;