Remember user decisions on invalid certificates behind a flag

chrome/browser/browsing_data/browsing_data_remover.cc

Index: chrome/browser/browsing_data/browsing_data_remover.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc
index 8b066105e1be5a5f37985e252830e587c19774b9..3e0927608a21d25550c4fdc89faa8c3f3c9682b2 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover.cc
@@ -73,6 +73,7 @@
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/plugin_data_remover.h"
 #include "content/public/browser/session_storage_usage_info.h"
+#include "content/public/browser/ssl_host_state_decisions.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/user_metrics.h"
 #include "net/base/net_errors.h"
@@ -401,6 +402,11 @@ void BrowsingDataRemover::RemoveImpl(int remove_mask,
         base::Bind(&BrowsingDataRemover::OnClearedWebRtcLogs,
                    base::Unretained(this)));
 #endif
+
+    // The SSL Host State that tracks SSL interstitial "proceed" decisions may
+    // include origins that the user has visited, so it must be cleared.
+    if (profile_->GetSSLHostStateDecisions())
+      profile_->GetSSLHostStateDecisions()->Clear();

[felt, 2014/07/07 22:26:39]

when this is called in Incognito, I assume this just clears the Incognito
decisions, not also the decisions from the parent profile that spawned the
Incognito profile?

[jww, 2014/07/08 17:35:41]

Correct. I've updated the browser tests in
chrome_ssl_host_state_decisions_test.cc to verify this.

   }
 
   if ((remove_mask & REMOVE_DOWNLOADS) && may_delete_history) {