Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 369673009: Change AndroidHistoryProviderService to use CancelableTaskTracker (2/6) (Closed)

Created:
6 years, 5 months ago by sdefresne
Modified:
6 years, 5 months ago
Reviewers:
Miguel Garcia, blundell
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cancelable_task_tracker.2
Project:
chromium
Visibility:
Public.

Description

Change AndroidHistoryProviderService to use CancelableTaskTracker (2/6) Port QueryHistoryAndBookmarks and QuerySearchTerms methods to use CancelableTaskTracker instead of CancelableRequestConsumer. BUG=371818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283527

Patch Set 1 #

Patch Set 2 : clang-format #

Total comments: 4

Patch Set 3 : Document methods #

Patch Set 4 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -87 lines) Patch
M chrome/browser/android/provider/chrome_browser_provider.cc View 1 2 2 chunks +19 lines, -16 lines 0 comments Download
M chrome/browser/history/android/android_history_provider_service.h View 1 2 4 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/history/android/android_history_provider_service.cc View 2 chunks +34 lines, -20 lines 0 comments Download
M chrome/browser/history/android/android_history_provider_service_unittest.cc View 1 2 3 5 chunks +18 lines, -10 lines 0 comments Download
M chrome/browser/history/android/sqlite_cursor_unittest.cc View 1 2 3 4 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 2 2 chunks +18 lines, -7 lines 0 comments Download
M chrome/browser/history/history_backend_android.cc View 2 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sdefresne
Could you please take a look? This is the second of a series of seven ...
6 years, 5 months ago (2014-07-03 17:17:28 UTC) #1
blundell
lgtm
6 years, 5 months ago (2014-07-04 09:42:16 UTC) #2
sdefresne
+miguelg for OWNERS of //chrome/browser/android
6 years, 5 months ago (2014-07-04 12:25:55 UTC) #3
Miguel Garcia
lgtm https://codereview.chromium.org/369673009/diff/20001/chrome/browser/history/history_backend.h File chrome/browser/history/history_backend.h (right): https://codereview.chromium.org/369673009/diff/20001/chrome/browser/history/history_backend.h#newcode331 chrome/browser/history/history_backend.h:331: history::AndroidStatement* QuerySearchTerms( nit: can you document what the ...
6 years, 5 months ago (2014-07-07 09:51:57 UTC) #4
sdefresne
https://codereview.chromium.org/369673009/diff/20001/chrome/browser/history/history_backend.h File chrome/browser/history/history_backend.h (right): https://codereview.chromium.org/369673009/diff/20001/chrome/browser/history/history_backend.h#newcode331 chrome/browser/history/history_backend.h:331: history::AndroidStatement* QuerySearchTerms( On 2014/07/07 09:51:57, Miguel Garcia wrote: > ...
6 years, 5 months ago (2014-07-16 08:07:24 UTC) #5
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 5 months ago (2014-07-16 08:08:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/369673009/40001
6 years, 5 months ago (2014-07-16 08:09:09 UTC) #7
sdefresne
The CQ bit was unchecked by sdefresne@chromium.org
6 years, 5 months ago (2014-07-16 11:53:20 UTC) #8
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 5 months ago (2014-07-16 12:07:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/369673009/60001
6 years, 5 months ago (2014-07-16 12:10:46 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 21:48:05 UTC) #11
Message was sent while issue was closed. 
Change committed as 283527

Powered by Google App Engine
This is Rietveld 408576698