Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7354)

Unified Diff: chrome/browser/history/history_backend.h

Issue 369673009: Change AndroidHistoryProviderService to use CancelableTaskTracker (2/6) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cancelable_task_tracker.2
Patch Set: Fix unit tests Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_backend.h
diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h
index cb1edb839ffcd1e159e8288a0cd9acdf1fadafd8..5f502862846bc4e2c62fb1a6c0a818fce6a9b6a4 100644
--- a/chrome/browser/history/history_backend.h
+++ b/chrome/browser/history/history_backend.h
@@ -285,8 +285,13 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
void InsertHistoryAndBookmark(scoped_refptr<InsertRequest> request,
const HistoryAndBookmarkRow& row);
- void QueryHistoryAndBookmarks(
- scoped_refptr<QueryRequest> request,
+ // Runs the given query on history backend and returns the result.
+ //
+ // |projections| is the vector of the result columns.
+ // |selection| is the SQL WHERE clause without 'WHERE'.
+ // |selection_args| is the arguments for WHERE clause.
+ // |sort_order| is the SQL ORDER clause.
+ history::AndroidStatement* QueryHistoryAndBookmarks(
const std::vector<HistoryAndBookmarkRow::ColumnID>& projections,
const std::string& selection,
const std::vector<base::string16>& selection_args,
@@ -330,11 +335,17 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
const std::string& selection,
const std::vector<base::string16> selection_args);
- void QuerySearchTerms(scoped_refptr<QueryRequest> request,
- const std::vector<SearchRow::ColumnID>& projections,
- const std::string& selection,
- const std::vector<base::string16>& selection_args,
- const std::string& sort_order);
+ // Returns the result of the given query.
+ //
+ // |projections| specifies the result columns.
+ // |selection| is the SQL WHERE clause without 'WHERE'.
+ // |selection_args| is the arguments for WHERE clause.
+ // |sort_order| is the SQL ORDER clause.
+ history::AndroidStatement* QuerySearchTerms(
+ const std::vector<SearchRow::ColumnID>& projections,
+ const std::string& selection,
+ const std::vector<base::string16>& selection_args,
+ const std::string& sort_order);
#endif // defined(OS_ANDROID)
« no previous file with comments | « chrome/browser/history/android/sqlite_cursor_unittest.cc ('k') | chrome/browser/history/history_backend_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698