Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 369573003: Do not create a temporary string to append the SVGLength's unit (Closed)

Created:
6 years, 5 months ago by rwlbuis
Modified:
6 years, 5 months ago
Reviewers:
pdr.
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Do not create a temporary string to append the SVGLength's unit This is a cherry-pick of Benjamin Poulain's patch from WebKit r132807. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/svg/SVGLength.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
rwlbuis
PTAL
6 years, 5 months ago (2014-07-02 21:38:53 UTC) #1
pdr.
On 2014/07/02 21:38:53, rwlbuis wrote: > PTAL LGTM. Took a minute because, embarrassingly, I had ...
6 years, 5 months ago (2014-07-02 22:13:23 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 5 months ago (2014-07-02 22:13:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/369573003/1
6 years, 5 months ago (2014-07-02 22:15:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-02 23:15:53 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-03 00:09:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15183)
6 years, 5 months ago (2014-07-03 00:09:31 UTC) #7
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 5 months ago (2014-07-03 01:15:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/369573003/1
6 years, 5 months ago (2014-07-03 01:15:56 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-03 02:15:46 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-03 03:03:15 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15211)
6 years, 5 months ago (2014-07-03 03:03:15 UTC) #12
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 5 months ago (2014-07-03 03:04:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/369573003/1
6 years, 5 months ago (2014-07-03 03:06:06 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 03:44:06 UTC) #15
Message was sent while issue was closed. 
Change committed as 177443

Powered by Google App Engine
This is Rietveld 408576698