Source/core/svg/SVGLength.cpp - Issue 369573003: Do not create a temporary string to append the SVGLength's unit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGLength.cpp

Issue 369573003: Do not create a temporary string to append the SVGLength's unit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGLength.cpp

diff --git a/Source/core/svg/SVGLength.cpp b/Source/core/svg/SVGLength.cpp

index 078305a27f78eca7cdce78609233ba8cef462149..7a243c02f5416019760ba9f77182a15dda6ff49e 100644

--- a/Source/core/svg/SVGLength.cpp

+++ b/Source/core/svg/SVGLength.cpp

@@ -37,7 +37,7 @@ namespace WebCore {

namespace {

-inline String lengthTypeToString(SVGLengthType type)

+inline const char* lengthTypeToString(SVGLengthType type)

{

switch (type) {

case LengthTypeUnknown:

@@ -64,7 +64,7 @@ inline String lengthTypeToString(SVGLengthType type)

}

ASSERT_NOT_REACHED();

- return String();

+ return "";

}

template<typename CharType>

« no previous file with comments | « no previous file | no next file » | no next file with comments »