Issue 369483003: Re-enable the check in GetRangeConstraint() function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 369483003: Re-enable the check in GetRangeConstraint() function. (Closed)

Created:
6 years, 5 months ago by tfarina

Modified:
6 years, 5 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
Jakob Kummerow, v8-dev

Base URL:
git://github.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Re-enable the check in GetRangeConstraint() function. Now that we have ASSERT() macro in src/base/logging.h we can use it in safe_conversions_impl.h, re-enable this assertion and fix the TODO there. BUG=None TEST=None R=jochen@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=22138

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/base/safe_conversions_impl.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

6 years, 5 months ago (2014-07-02 07:02:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22138 (presubmit successful).

Expand Messages | Collapse Messages