Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: src/base/safe_conversions_impl.h

Issue 369483003: Re-enable the check in GetRangeConstraint() function. (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/base/safe_conversions_impl.h
diff --git a/src/base/safe_conversions_impl.h b/src/base/safe_conversions_impl.h
index 2226f17aebd1a2a2367d99e1178cb7bcd4efd668..0a9ed9b71978eb55690bb403029988a603958db3 100644
--- a/src/base/safe_conversions_impl.h
+++ b/src/base/safe_conversions_impl.h
@@ -10,6 +10,7 @@
#include <limits>
+#include "src/base/logging.h"
#include "src/base/macros.h"
namespace v8 {
@@ -98,9 +99,8 @@ enum RangeConstraint {
// Helper function for coercing an int back to a RangeContraint.
inline RangeConstraint GetRangeConstraint(int integer_range_constraint) {
- // TODO(jochen/jkummerow): Re-enable this when checks.h is available in base.
- // ASSERT(integer_range_constraint >= RANGE_VALID &&
- // integer_range_constraint <= RANGE_INVALID);
+ ASSERT(integer_range_constraint >= RANGE_VALID &&
+ integer_range_constraint <= RANGE_INVALID);
return static_cast<RangeConstraint>(integer_range_constraint);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698