Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 369473005: rebaseline_server: handle category filtering more generically (Closed)

Created:
6 years, 5 months ago by epoger
Modified:
6 years, 5 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

rebaseline_server: handle category filtering more generically closed in favor of https://codereview.chromium.org/369133004 BUG=skia:2230

Patch Set 1 : replace special-purpose hiddenConfigs/hiddenResultTypes sets with generic hiddenColumnValues #

Patch Set 2 : invert hiddenColumnValues to showingColumnValues; makes filtered URLs more understandable #

Patch Set 3 : make UI code display categories in a loop, rather than hard-coded for each category type #

Patch Set 4 : rebase after https://codereview.chromium.org/368933002/ (urlSchemaVersion) #

Patch Set 5 : increment urlSchemaVersion and convert old URLs (hiddenConfigs->config, etc.) #

Patch Set 6 : rebase after https://codereview.chromium.org/364253003/ ('rebaseline_server: if urlSchemaVersion is… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -128 lines) Patch
M gm/rebaseline_server/static/loader.js View 1 2 3 4 5 12 chunks +105 lines, -71 lines 0 comments Download
M gm/rebaseline_server/static/view.html View 1 2 3 6 chunks +34 lines, -57 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698