rebaseline_server: handle column filtering more generically

rebaseline_server: handle column filtering more generically

This is a step towards making rebaseline_server more flexible, and useful for displaying output of the cluster telemetry server as well as actuals-on-configA-vs-actuals-on-configB.

BUG=skia:2230
Committed: https://skia.googlesource.com/skia/+/df55f0632ad3f860d629a5cd39bbecf93d878ac2

[epoger, 2014-07-03 21:49:46]

Ravi- PTAL as of patchset 6.

Eric- FYI. See below for a comment directed at you.

You can try it out:
rebaseline_server before this CL: http://172.24.179.183:2222
rebaseline_server after this CL:  http://172.24.179.183:3333

https://codereview.chromium.org/369133004/diff/100001/gm/rebaseline_server/st...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/369133004/diff/100001/gm/rebaseline_server/st...
gm/rebaseline_server/static/loader.js:33: return function(unfilteredImagePairs,
showingColumnValues,
Throughout:
- (hiddenResultTypes, hiddenConfigs) data structures were combined into a single
generic hiddenColumnValues data structure
- I inverted the name/meaning to be the set of values to SHOW, not the set of
values to HIDE.  This makes the URL more understandable.

https://codereview.chromium.org/369133004/diff/100001/gm/rebaseline_server/st...
gm/rebaseline_server/static/loader.js:451: // The combination of:
Eric- I figured out a way to properly handle any of those old rebaseline_server
URLs.  In my manual testing, they convert over just fine.

https://codereview.chromium.org/369133004/diff/100001/gm/rebaseline_server/st...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/369133004/diff/100001/gm/rebaseline_server/st...
gm/rebaseline_server/static/view.html:121: <button
ng-click="showingColumnValues[constants.KEY__EXTRACOLUMNS__CONFIG] = {};
toggleValuesInSet(allColumnValues[constants.KEY__EXTRACOLUMNS__CONFIG],
showingColumnValues[constants.KEY__EXTRACOLUMNS__CONFIG]); updateResults()"
These action definitions are long and unwieldy.  But in a coming CL, I will
improve it (and reduce file length, and increase flexibility) by looping over
the various columns rather than handling resultTypes and configs separately.

You can see a preview of the looping change at
https://codereview.chromium.org/369473005/diff2/20001:40001/gm/rebaseline_ser...

I will make that change in a coming CL, along with the following changes that
need to happen at the same time:
  - allow server to specify which columns we filter with checkboxes vs text
matching
  - allow server to specify display order of columns

[rmistry, 2014-07-07 15:28:52]

LGTM

https://codereview.chromium.org/369133004/diff/100001/gm/rebaseline_server/st...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/369133004/diff/100001/gm/rebaseline_server/st...
gm/rebaseline_server/static/loader.js:33: return function(unfilteredImagePairs,
showingColumnValues,
On 2014/07/03 21:49:46, epoger wrote:
> Throughout:
> - (hiddenResultTypes, hiddenConfigs) data structures were combined into a
single
> generic hiddenColumnValues data structure
> - I inverted the name/meaning to be the set of values to SHOW, not the set of
> values to HIDE.  This makes the URL more understandable.

Acknowledged.

https://codereview.chromium.org/369133004/diff/100001/gm/rebaseline_server/st...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/369133004/diff/100001/gm/rebaseline_server/st...
gm/rebaseline_server/static/view.html:121: <button
ng-click="showingColumnValues[constants.KEY__EXTRACOLUMNS__CONFIG] = {};
toggleValuesInSet(allColumnValues[constants.KEY__EXTRACOLUMNS__CONFIG],
showingColumnValues[constants.KEY__EXTRACOLUMNS__CONFIG]); updateResults()"
On 2014/07/03 21:49:46, epoger wrote:
> These action definitions are long and unwieldy.  But in a coming CL, I will
> improve it (and reduce file length, and increase flexibility) by looping over
> the various columns rather than handling resultTypes and configs separately.
> 
> You can see a preview of the looping change at
>
https://codereview.chromium.org/369473005/diff2/20001:40001/gm/rebaseline_ser...
> 
> I will make that change in a coming CL, along with the following changes that
> need to happen at the same time:
>   - allow server to specify which columns we filter with checkboxes vs text
> matching
>   - allow server to specify display order of columns

Acknowledged.

[epoger, 2014-07-07 15:30:02]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-07-07 15:31:09]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/epoger@google.com/369133004/100001

[commit-bot: I haz the power, 2014-07-07 15:49:18]

Change committed as df55f0632ad3f860d629a5cd39bbecf93d878ac2