Fix component build linking with notifications=0

Fix component build linking with notifications=0

We will get the following errors if not:

2>     Creating library ..\..\build\Debug\lib\message_center.lib and object ..\..\build\Debug\lib\message_center.exp
2>dummy_message_center.obj : error LNK2001: unresolved external symbol "public: virtual bool __thiscall message_center::NotificationDelegate::HasClickedListener(void)" (?HasClickedListener@NotificationDelegate@message_center@@UAE_NXZ)
2>dummy_message_center.obj : error LNK2001: unresolved external symbol "public: virtual void __thiscall message_center::NotificationDelegate::ButtonClick(int)" (?ButtonClick@NotificationDelegate@message_center@@UAEXH@Z)

Same fix for OS==android.

Done by Przemek Kudla <pkudla@opera.com>;

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281574

[Peter Beverloo, 2014-07-04 15:07:26]

This looks good to me. I've launched a bunch of try-bots for you.

https://codereview.chromium.org/369243002/diff/1/ui/message_center/message_ce...
File ui/message_center/message_center.gyp (left):

https://codereview.chromium.org/369243002/diff/1/ui/message_center/message_ce...
ui/message_center/message_center.gyp:152: ['include',
'^notifier_settings\\.cc$'],
Are you sure we don't need the NotifierId stuff defined in this file for
Android?

https://codereview.chromium.org/369243002/diff/1/ui/message_center/message_ce...
File ui/message_center/message_center.gyp (right):

https://codereview.chromium.org/369243002/diff/1/ui/message_center/message_ce...
ui/message_center/message_center.gyp:152: ['include',
'^notification_delegate\\.cc$'],
This line can be removed since we'll already include it for Android on line 143.

[Jiang Jiang, 2014-07-04 15:14:15]

https://codereview.chromium.org/369243002/diff/1/ui/message_center/message_ce...
File ui/message_center/message_center.gyp (right):

https://codereview.chromium.org/369243002/diff/1/ui/message_center/message_ce...
ui/message_center/message_center.gyp:152: ['include',
'^notification_delegate\\.cc$'],
On 2014/07/04 15:07:26, Peter Beverloo wrote:
> This line can be removed since we'll already include it for Android on line
143.

Ah sorry, I deleted the wrong line.

[Jiang Jiang, 2014-07-04 15:16:47]

https://codereview.chromium.org/369243002/diff/1/ui/message_center/message_ce...
File ui/message_center/message_center.gyp (left):

https://codereview.chromium.org/369243002/diff/1/ui/message_center/message_ce...
ui/message_center/message_center.gyp:152: ['include',
'^notifier_settings\\.cc$'],
On 2014/07/04 15:07:26, Peter Beverloo wrote:
> Are you sure we don't need the NotifierId stuff defined in this file for
> Android?

It was accidentally deleted, restored.

[Jiang Jiang, 2014-07-04 15:37:20]

On 2014/07/04 15:16:47, Jiang wrote:
>
https://codereview.chromium.org/369243002/diff/1/ui/message_center/message_ce...
> File ui/message_center/message_center.gyp (left):
> 
>
https://codereview.chromium.org/369243002/diff/1/ui/message_center/message_ce...
> ui/message_center/message_center.gyp:152: ['include',
> '^notifier_settings\\.cc$'],
> On 2014/07/04 15:07:26, Peter Beverloo wrote:
> > Are you sure we don't need the NotifierId stuff defined in this file for
> > Android?
> 
> It was accidentally deleted, restored.

Not quite sure why android try servers are failing.

[Jiang Jiang, 2014-07-07 08:58:06]

On 2014/07/04 15:37:20, Jiang wrote:
> On 2014/07/04 15:16:47, Jiang wrote:
> >
>
https://codereview.chromium.org/369243002/diff/1/ui/message_center/message_ce...
> > File ui/message_center/message_center.gyp (left):
> > 
> >
>
https://codereview.chromium.org/369243002/diff/1/ui/message_center/message_ce...
> > ui/message_center/message_center.gyp:152: ['include',
> > '^notifier_settings\\.cc$'],
> > On 2014/07/04 15:07:26, Peter Beverloo wrote:
> > > Are you sure we don't need the NotifierId stuff defined in this file for
> > > Android?
> > 
> > It was accidentally deleted, restored.
> 
> Not quite sure why android try servers are failing.

Peter, can you please take another look at the patch?

[Peter Beverloo, 2014-07-07 09:18:27]

lgtm, but you'll need a stamp from the OWNERS.

I've launched a bunch of new try-bots too, both Android ones flaked on this
build :/.

[Jiang Jiang, 2014-07-07 09:21:16]

On 2014/07/07 09:18:27, Peter Beverloo wrote:
> lgtm, but you'll need a stamp from the OWNERS.
> 
> I've launched a bunch of new try-bots too, both Android ones flaked on this
> build :/.

Thanks Peter, so should I ping stevenjb or mukai for this review?

[Peter Beverloo, 2014-07-07 09:41:32]

On 2014/07/07 09:21:16, Jiang wrote:
> On 2014/07/07 09:18:27, Peter Beverloo wrote:
> > lgtm, but you'll need a stamp from the OWNERS.
> > 
> > I've launched a bunch of new try-bots too, both Android ones flaked on this
> > build :/.
> 
> Thanks Peter, so should I ping stevenjb or mukai for this review?

Either will work :-). Basically anyone from the OWNERS file in either
src/ui/message_center/, src/ui/ or src/ will be able to review your patch.

Thanks for the patch!

[Jiang Jiang, 2014-07-07 12:37:48]

dewittj, can you please take a look at this CL as well?

[Jun Mukai, 2014-07-07 17:02:39]

lgtm.

I think dewittj is on leave

[Jiang Jiang, 2014-07-07 18:02:40]

The CQ bit was checked by jiangj@opera.com

[Jiang Jiang, 2014-07-07 18:02:49]

On 2014/07/07 17:02:39, Jun Mukai wrote:
> lgtm.
> 
> I think dewittj is on leave

Thanks!

[commit-bot: I haz the power, 2014-07-07 18:03:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jiangj@opera.com/369243002/20001

[commit-bot: I haz the power, 2014-07-07 19:57:33]

Change committed as 281574