Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: ui/message_center/message_center.gyp

Issue 369243002: Fix component build linking with notifications=0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move notification_delegate match correctly. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1, 7 'chromium_code': 1,
8 }, 8 },
9 'targets': [ 9 'targets': [
10 { 10 {
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 ], 133 ],
134 }], 134 }],
135 # iOS disables notifications altogether, Android implements its own 135 # iOS disables notifications altogether, Android implements its own
136 # notification UI manager instead of deferring to the message center. 136 # notification UI manager instead of deferring to the message center.
137 ['notifications==0 or OS=="android"', { 137 ['notifications==0 or OS=="android"', {
138 'sources/': [ 138 'sources/': [
139 # Exclude everything except dummy impl. 139 # Exclude everything except dummy impl.
140 ['exclude', '\\.(cc|mm)$'], 140 ['exclude', '\\.(cc|mm)$'],
141 ['include', '^dummy_message_center\\.cc$'], 141 ['include', '^dummy_message_center\\.cc$'],
142 ['include', '^message_center_switches\\.cc$'], 142 ['include', '^message_center_switches\\.cc$'],
143 ['include', '^notification_delegate\\.cc$'],
143 ], 144 ],
144 }, { # notifications==1 145 }, { # notifications==1
145 'sources!': [ 'dummy_message_center.cc' ], 146 'sources!': [ 'dummy_message_center.cc' ],
146 }], 147 }],
147 # Include a minimal set of files required for notifications on Android. 148 # Include a minimal set of files required for notifications on Android.
148 ['OS=="android"', { 149 ['OS=="android"', {
149 'sources/': [ 150 'sources/': [
150 ['include', '^notification\\.cc$'], 151 ['include', '^notification\\.cc$'],
151 ['include', '^notification_delegate\\.cc$'],
152 ['include', '^notifier_settings\\.cc$'], 152 ['include', '^notifier_settings\\.cc$'],
153 ], 153 ],
154 }], 154 }],
155 ], 155 ],
156 }, # target_name: message_center 156 }, # target_name: message_center
157 { 157 {
158 'target_name': 'message_center_test_support', 158 'target_name': 'message_center_test_support',
159 'type': 'static_library', 159 'type': 'static_library',
160 'dependencies': [ 160 'dependencies': [
161 '../../base/base.gyp:base', 161 '../../base/base.gyp:base',
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 # See http://crbug.com/162998#c4 for why this is needed. 238 # See http://crbug.com/162998#c4 for why this is needed.
239 ['OS=="linux" and use_allocator!="none"', { 239 ['OS=="linux" and use_allocator!="none"', {
240 'dependencies': [ 240 'dependencies': [
241 '../../base/allocator/allocator.gyp:allocator', 241 '../../base/allocator/allocator.gyp:allocator',
242 ], 242 ],
243 }], 243 }],
244 ], 244 ],
245 }, # target_name: message_center_unittests 245 }, # target_name: message_center_unittests
246 ], 246 ],
247 } 247 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698