Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: chrome/browser/android/tab_android.h

Issue 368983004: Implemented HandlePopupNavigation from tab_android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/tab_android.h
diff --git a/chrome/browser/android/tab_android.h b/chrome/browser/android/tab_android.h
index 0ee5392e2a471a6176e6afb9ea5dbf83652b5aff..8f4a873d35c592fd2a5460afde8fa554b66fefc0 100644
--- a/chrome/browser/android/tab_android.h
+++ b/chrome/browser/android/tab_android.h
@@ -147,6 +147,10 @@ class TabAndroid : public CoreTabHelperDelegate,
jstring jurl,
jstring jtitle);
bool Print(JNIEnv* env, jobject obj);
+ content::WebContents* CreateTargetContents(const chrome::NavigateParams& params,
Bernhard Bauer 2014/07/04 14:06:29 Nit: Break this to fit into 80 columns, and fix al
Bernhard Bauer 2014/07/04 14:06:29 These don't need to be public. In fact, they can p
Jitu( very slow this week) 2014/07/04 16:00:52 Done.
+ const GURL& url);
+ void LoadURLInContents(content::WebContents* target_contents, const GURL& url,
+ chrome::NavigateParams* params);
// Register the Tab's native methods through JNI.
static bool RegisterTabAndroid(JNIEnv* env);

Powered by Google App Engine
This is Rietveld 408576698