Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: chrome/browser/android/tab_android.h

Issue 368983004: Implemented HandlePopupNavigation from tab_android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_TAB_ANDROID_H_ 5 #ifndef CHROME_BROWSER_ANDROID_TAB_ANDROID_H_
6 #define CHROME_BROWSER_ANDROID_TAB_ANDROID_H_ 6 #define CHROME_BROWSER_ANDROID_TAB_ANDROID_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/jni_weak_ref.h" 10 #include "base/android/jni_weak_ref.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 jint page_transition, 140 jint page_transition,
141 jstring j_referrer_url, 141 jstring j_referrer_url,
142 jint referrer_policy, 142 jint referrer_policy,
143 jboolean is_renderer_initiated); 143 jboolean is_renderer_initiated);
144 ToolbarModel::SecurityLevel GetSecurityLevel(JNIEnv* env, jobject obj); 144 ToolbarModel::SecurityLevel GetSecurityLevel(JNIEnv* env, jobject obj);
145 void SetActiveNavigationEntryTitleForUrl(JNIEnv* env, 145 void SetActiveNavigationEntryTitleForUrl(JNIEnv* env,
146 jobject obj, 146 jobject obj,
147 jstring jurl, 147 jstring jurl,
148 jstring jtitle); 148 jstring jtitle);
149 bool Print(JNIEnv* env, jobject obj); 149 bool Print(JNIEnv* env, jobject obj);
150 content::WebContents* CreateTargetContents(const chrome::NavigateParams& param s,
Bernhard Bauer 2014/07/04 14:06:29 Nit: Break this to fit into 80 columns, and fix al
Bernhard Bauer 2014/07/04 14:06:29 These don't need to be public. In fact, they can p
Jitu( very slow this week) 2014/07/04 16:00:52 Done.
151 const GURL& url);
152 void LoadURLInContents(content::WebContents* target_contents, const GURL& url,
153 chrome::NavigateParams* params);
150 154
151 // Register the Tab's native methods through JNI. 155 // Register the Tab's native methods through JNI.
152 static bool RegisterTabAndroid(JNIEnv* env); 156 static bool RegisterTabAndroid(JNIEnv* env);
153 157
154 private: 158 private:
155 prerender::PrerenderManager* GetPrerenderManager() const; 159 prerender::PrerenderManager* GetPrerenderManager() const;
156 160
157 JavaObjectWeakGlobalRef weak_java_tab_; 161 JavaObjectWeakGlobalRef weak_java_tab_;
158 162
159 // The identifier used by session restore for this tab. 163 // The identifier used by session restore for this tab.
160 SessionID session_tab_id_; 164 SessionID session_tab_id_;
161 165
162 // Identifier of the window the tab is in. 166 // Identifier of the window the tab is in.
163 SessionID session_window_id_; 167 SessionID session_window_id_;
164 168
165 content::NotificationRegistrar notification_registrar_; 169 content::NotificationRegistrar notification_registrar_;
166 170
167 scoped_ptr<content::WebContents> web_contents_; 171 scoped_ptr<content::WebContents> web_contents_;
168 scoped_ptr<chrome::android::ChromeWebContentsDelegateAndroid> 172 scoped_ptr<chrome::android::ChromeWebContentsDelegateAndroid>
169 web_contents_delegate_; 173 web_contents_delegate_;
170 174
171 scoped_ptr<browser_sync::SyncedTabDelegateAndroid> synced_tab_delegate_; 175 scoped_ptr<browser_sync::SyncedTabDelegateAndroid> synced_tab_delegate_;
172 176
173 DISALLOW_COPY_AND_ASSIGN(TabAndroid); 177 DISALLOW_COPY_AND_ASSIGN(TabAndroid);
174 }; 178 };
175 179
176 #endif // CHROME_BROWSER_ANDROID_TAB_ANDROID_H_ 180 #endif // CHROME_BROWSER_ANDROID_TAB_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698