rebaseline_server: add urlSchemaVersion parameter

rebaseline_server: add urlSchemaVersion parameter

In https://codereview.chromium.org/369473005 ('rebaseline_server: handle category filtering more generically'), I am changing the meaning of some URL parameters.  If a user pastes an old URL into an updated rebaseline_server instance, they may get unexpected results.  Adding a urlSchemaVersion parameter allows us to automatically convert the URL, or at least warn the user.

BUG=skia:2230
NOTRY=True

Committed: https://skia.googlesource.com/skia/+/e5481eca7e66fd194c3b897fa3b8911cfe420958

[epoger, 2014-07-02 19:27:08]

Joe- PTAL at patchset 1.

https://codereview.chromium.org/368933002/diff/1/gm/rebaseline_server/server.py
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/368933002/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:2: 
Reason for the change:

In https://codereview.chromium.org/369473005 ('rebaseline_server: handle
category filtering more generically'), I am changing the meaning of some URL
parameters.  If a user pastes an old URL into an updated rebaseline_server
instance, they may get unexpected results.  Adding a urlSchemaVersion parameter
allows us to automatically convert the URL, or at least warn the user.

I should have done this in the first place. :-\

https://codereview.chromium.org/368933002/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:28: # Must fix up PYTHONPATH before importing
from within Skia
Cleaned up this and various other pylint warnings/failures while I was in here. 
(pylint didn't used to run as a presubmit check, but now it does)

[jcgregorio, 2014-07-02 20:19:21]

https://codereview.chromium.org/368933002/diff/1/gm/rebaseline_server/server.py
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/368933002/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:2: 
Can you move this up into the CL description?

On 2014/07/02 19:27:08, epoger wrote:
> Reason for the change:
> 
> In https://codereview.chromium.org/369473005 ('rebaseline_server: handle
> category filtering more generically'), I am changing the meaning of some URL
> parameters.  If a user pastes an old URL into an updated rebaseline_server
> instance, they may get unexpected results.  Adding a urlSchemaVersion
parameter
> allows us to automatically convert the URL, or at least warn the user.
> 
> I should have done this in the first place. :-\

https://codereview.chromium.org/368933002/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:172: '<a
href="/%s/view.html#/view.html?%s=%s&resultsToLoad=/%s/%s">'
What's the upper limit for number of % parameters before switching to
string.Template?

[epoger, 2014-07-02 20:47:18]

https://codereview.chromium.org/368933002/diff/1/gm/rebaseline_server/server.py
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/368933002/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:2: 
On 2014/07/02 20:19:20, jcgregorio wrote:
> Can you move this up into the CL description?

Done.  (I originally put it here to make it easier to ask questions about this
specific comment inline using Rietveld replies.)

https://codereview.chromium.org/368933002/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:172: '<a
href="/%s/view.html#/view.html?%s=%s&resultsToLoad=/%s/%s">'
On 2014/07/02 20:19:20, jcgregorio wrote:
> What's the upper limit for number of % parameters before switching to
> string.Template?

I dunno.  Do you like this better?  I think it's better.

[jcgregorio, 2014-07-02 20:48:54]

LGTM

https://codereview.chromium.org/368933002/diff/1/gm/rebaseline_server/server.py
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/368933002/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:172: '<a
href="/%s/view.html#/view.html?%s=%s&resultsToLoad=/%s/%s">'
Yes, I like that much better.

On 2014/07/02 20:47:18, epoger wrote:
> On 2014/07/02 20:19:20, jcgregorio wrote:
> > What's the upper limit for number of % parameters before switching to
> > string.Template?
> 
> I dunno.  Do you like this better?  I think it's better.

[epoger, 2014-07-02 20:50:32]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-07-02 20:51:35]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/epoger@google.com/368933002/20001

[commit-bot: I haz the power, 2014-07-02 20:51:51]

Change committed as e5481eca7e66fd194c3b897fa3b8911cfe420958

[epoger, 2014-07-03 17:51:36]

Modified in https://codereview.chromium.org/364253003/ ('rebaseline_server: if
urlSchemaVersion is not specified, assume current')