Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: Source/bindings/core/v8/ScriptWrappable.h

Issue 368853002: Add ScriptForbiddenScope to weak callbacks of DOM wrappers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/DOMWrapperMap.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptWrappable.h
diff --git a/Source/bindings/core/v8/ScriptWrappable.h b/Source/bindings/core/v8/ScriptWrappable.h
index e8a741da70c795dbcf1fdb71ff09cc5d3e93c4c4..380f509b64eb830d7fd79db14e058c9e717ea42c 100644
--- a/Source/bindings/core/v8/ScriptWrappable.h
+++ b/Source/bindings/core/v8/ScriptWrappable.h
@@ -32,6 +32,7 @@
#define ScriptWrappable_h
#include "bindings/core/v8/WrapperTypeInfo.h"
+#include "core/dom/ScriptForbiddenScope.h"
#include "platform/heap/Handle.h"
#include <v8.h>
@@ -252,6 +253,7 @@ private:
static void setWeakCallback(const v8::WeakCallbackData<v8::Object, ScriptWrappable>& data)
{
+ ScriptForbiddenScope forbiddenScope;
jochen (gone - plz use gerrit) 2014/07/02 11:21:54 why here?
haraken 2014/07/02 11:23:13 Because this calls releaseObject() for DOM wrapper
v8::Persistent<v8::Object> persistent;
data.GetParameter()->getPersistent(&persistent);
ASSERT(persistent == data.GetValue());
« no previous file with comments | « Source/bindings/core/v8/DOMWrapperMap.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698