Add ScriptForbiddenScope to weak callbacks of DOM wrappers

Source/bindings/core/v8/ScriptWrappable.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef ScriptWrappable_h
 #define ScriptWrappable_h
 
 #include "bindings/core/v8/WrapperTypeInfo.h"
+#include "core/dom/ScriptForbiddenScope.h"
 #include "platform/heap/Handle.h"
 #include <v8.h>
 
 // Helper to call webCoreInitializeScriptWrappableForInterface in the global namespace.
 template <class C> inline void initializeScriptWrappableHelper(C* object)
 {
     void webCoreInitializeScriptWrappableForInterface(C*);
     webCoreInitializeScriptWrappableForInterface(object);
 }
 
@@ skipping 200 matching lines @@
         setTypeInfo(toWrapperTypeInfo(wrapper));
     }
 
     // If zero, then this contains nothing, otherwise:
     //   If the bottom bit it set, then this contains a pointer to a wrapper object in the remainging bits.
     //   If the bottom bit is clear, then this contains a pointer to the wrapper type info in the remaining bits.
     uintptr_t m_wrapperOrTypeInfo;
 
     static void setWeakCallback(const v8::WeakCallbackData<v8::Object, ScriptWrappable>& data)
     {
+        ScriptForbiddenScope forbiddenScope;

[jochen (gone - plz use gerrit), 2014/07/02 11:21:54]

why here?

[haraken, 2014/07/02 11:23:13]

Because this calls releaseObject() for DOM wrappers stored in ScriptWrappable.

         v8::Persistent<v8::Object> persistent;
         data.GetParameter()->getPersistent(&persistent);
         ASSERT(persistent == data.GetValue());
         data.GetParameter()->disposeWrapper(data.GetValue());
 
         // FIXME: I noticed that 50%~ of minor GC cycle times can be consumed
         // inside data.GetParameter()->deref(), which causes Node destructions. We should
         // make Node destructions incremental.
         releaseObject(data.GetValue());
     }
 };
 
 } // namespace WebCore
 
 #endif // ScriptWrappable_h