Restore interpretation of Dart null as undefined in dartToScriptValueWithNullCheck.

Restore interpretation of Dart null as undefined in dartToScriptValueWithNullCheck.

BUG=http://dartbug.com/19458
BUG=http://dartbug.com/18931 (html/indexeddb_5_test)
R=vsm@google.com

Committed: https://src.chromium.org/viewvc/multivm/branches/1650/blink?view=rev&revision=177325

[rmacnak, 2014-07-01 17:05:51]

Cf. https://codereview.chromium.org/360803002/

[vsm, 2014-07-01 17:12:53]

lgtm

https://codereview.chromium.org/368663002/diff/1/Source/bindings/dart/DartUti...
File Source/bindings/dart/DartUtilities.h (right):

https://codereview.chromium.org/368663002/diff/1/Source/bindings/dart/DartUti...
Source/bindings/dart/DartUtilities.h:539: return ScriptValue(scriptState,
v8::Undefined(scriptState->isolate()));
Did you consider a DartScriptValue wrapping undefined?

[rmacnak, 2014-07-01 17:20:02]

https://codereview.chromium.org/368663002/diff/1/Source/bindings/dart/DartUti...
File Source/bindings/dart/DartUtilities.h (right):

https://codereview.chromium.org/368663002/diff/1/Source/bindings/dart/DartUti...
Source/bindings/dart/DartUtilities.h:539: return ScriptValue(scriptState,
v8::Undefined(scriptState->isolate()));
On 2014/07/01 17:12:52, vsm wrote:
> Did you consider a DartScriptValue wrapping undefined?  

Right now a DartScriptValue never has an empty handle, so I considered
interpreting the empty handle as undefined. But this would require special cases
in DartScriptValue toString, toJSON, etc, so I think keeping undefined in V8
land is cleaner.

[vsm, 2014-07-01 17:22:48]

On 2014/07/01 17:20:02, rmacnak wrote:
>
https://codereview.chromium.org/368663002/diff/1/Source/bindings/dart/DartUti...
> File Source/bindings/dart/DartUtilities.h (right):
> 
>
https://codereview.chromium.org/368663002/diff/1/Source/bindings/dart/DartUti...
> Source/bindings/dart/DartUtilities.h:539: return ScriptValue(scriptState,
> v8::Undefined(scriptState->isolate()));
> On 2014/07/01 17:12:52, vsm wrote:
> > Did you consider a DartScriptValue wrapping undefined?  
> 
> Right now a DartScriptValue never has an empty handle, so I considered
> interpreting the empty handle as undefined. But this would require special
cases
> in DartScriptValue toString, toJSON, etc, so I think keeping undefined in V8
> land is cleaner.

Makes sense.  Still LGTM.

[rmacnak, 2014-07-01 17:53:43]

Committed patchset #1 manually as r177325 (presubmit successful).