Issue 360803002: Interpret Dart null as both null and undefined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 360803002: Interpret Dart null as both null and undefined. (Closed)

Created:
6 years, 5 months ago by rmacnak

Modified:
6 years, 5 months ago

Reviewers:
vsm, Leaf, terry

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/blink/branches/dart/1985

Visibility:
Public.

More Reviews

Description

Interpret Dart null as both null and undefined. BUG=http://dartbug.com/19458 BUG=http://dartbug.com/18931 (html/indexeddb_5_test)

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/bindings/dart/DartScriptValue.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rmacnak

I don't like this change as it may have unintended consequences for other parts of ...

6 years, 5 months ago (2014-06-30 22:14:48 UTC) #1

vsm

6 years, 5 months ago (2014-07-01 05:53:06 UTC) #2

On 2014/06/30 22:14:48, rmacnak wrote:
> I don't like this change as it may have unintended consequences for other
parts
> of dart:html.
> 
> Alternatively we could change IDBObjectStore::put to look for null or
undefined,
> but this would change Javascript behavior.
> 
> Thoughts?

I think we need to somehow undo this change from before:

https://codereview.chromium.org/289083003/diff/110001/Source/bindings/dart/Da...

I.e., in dartToScriptValueWithNullCheck, we need a way of creating a ScriptValue
that represents undefined.

Expand Messages | Collapse Messages