Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 368583004: Use IDL default arguments for Window.confirm() and Window.prompt() (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@idl-treatreturnednullstringas-simple
Project:
blink
Visibility:
Public.

Description

Use IDL default arguments for Window.confirm() and Window.prompt() This doesn't change behavior. BUG=258153 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/frame/Window.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jens Widell
PTAL
6 years, 5 months ago (2014-07-01 12:50:10 UTC) #1
haraken
The change makes a lot of sense. LGTM.
6 years, 5 months ago (2014-07-01 13:00:49 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-07-01 13:02:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/368583004/1
6 years, 5 months ago (2014-07-01 13:03:44 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 14:05:21 UTC) #5
Message was sent while issue was closed.
Change committed as 177309

Powered by Google App Engine
This is Rietveld 408576698