Source/core/frame/Window.idl - Issue 368583004: Use IDL default arguments for Window.confirm() and Window.prompt()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/Window.idl

Issue 368583004: Use IDL default arguments for Window.confirm() and Window.prompt() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-treatreturnednullstringas-simple

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/Window.idl

diff --git a/Source/core/frame/Window.idl b/Source/core/frame/Window.idl

index b0020e85a47ead12b96b84fb8fc51b508a998e0d..a742c817360dd24bbf231d80ab79077d8e194cb2 100644

--- a/Source/core/frame/Window.idl

+++ b/Source/core/frame/Window.idl

@@ -69,9 +69,9 @@

void alert();

void alert(DOMString message);

- boolean confirm(optional DOMString message = null);

- DOMString? prompt(optional DOMString message = null,

- optional DOMString defaultValue = null);

+ boolean confirm(optional DOMString message = "");

+ DOMString? prompt(optional DOMString message = "",

+ optional DOMString defaultValue = "");

boolean find([Default=Undefined] optional DOMString string,

[Default=Undefined] optional boolean caseSensitive,

« no previous file with comments | « no previous file | no next file » | no next file with comments »