runtime/vm/object.h - Issue 368483004: Avoid unnecessary copying when parsing doubles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.h

Issue 368483004: Avoid unnecessary copying when parsing doubles. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Also use the native parse directly in JSON parsing. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.h

diff --git a/runtime/vm/object.h b/runtime/vm/object.h

index 7eee7301144974673bc71d31f26f867436d89c7b..607ee3a0bd27c549b8d446b2429621ae7669f1ec 100644

--- a/runtime/vm/object.h

+++ b/runtime/vm/object.h

@@ -2751,6 +2751,7 @@ class Library : public Object {

static void InitNativeWrappersLibrary(Isolate* isolate);

static RawLibrary* AsyncLibrary();

+ static RawLibrary* ConvertLibrary();

static RawLibrary* CoreLibrary();

static RawLibrary* CollectionLibrary();

static RawLibrary* InternalLibrary();

@@ -5495,6 +5496,11 @@ class String : public Instance {

PRINTF_ATTRIBUTE(1, 2);

static RawString* NewFormattedV(const char* format, va_list args);

+ static bool ParseDouble(const String& str,

+ intptr_t start,

+ intptr_t end,

+ double* result);

protected:

bool HasHash() const {

ASSERT(Smi::New(0) == NULL);