Avoid unnecessary copying when parsing doubles.

runtime/lib/double_patch.dart

Index: runtime/lib/double_patch.dart
diff --git a/runtime/lib/double_patch.dart b/runtime/lib/double_patch.dart
index d0367250dcd2cb082e021cd29d07df65a046c843..ea34f7765d81c0b5e46d4e1cc2d3ad9a04f52dd0 100644
--- a/runtime/lib/double_patch.dart
+++ b/runtime/lib/double_patch.dart
@@ -7,34 +7,17 @@
 
 patch class double {
 
-  static double _native_parse(_OneByteString string) native "Double_parse";
+  static double _native_parse(String str,

[Vyacheslav Egorov (Google), 2014/07/01 11:36:18]

Should not this be called _nativeParse? _native_parse violates the style guide.

Also instead of double linking to it from double._native_parse and _JsonParser
could we have moved it to dart:_internal?

[Lasse Reichstein Nielsen, 2014/07/01 11:54:18]

Changed to _nativeParse.

Moving it to dart:_internal would mean that it's also visible to dart2js, which
we don't want.

It might be possible to add a function in the internal_patch.dart file, but it
violates the way patch files are *supposed* to work (only add private names or
patch external names). I'd prefer not to do that.

+                              int start, int end) native "Double_parse";
 
   static double _parse(var str) {
-    str = str.trim();
+    int len = str.length;
+    int start = str._firstNonWhitespace();
+    if (start == len) return null;  // All whitespace.
+    int end = str._lastNonWhitespace() + 1;
+    assert(start < end);
 
-    if (str.length == 0) return null;
-
-    final ccid = ClassID.getID(str);
-    _OneByteString oneByteString;
-    // TODO(Srdjan): Allow _ExternalOneByteStrings.
-    if (ccid == ClassID.cidOneByteString) {
-      oneByteString = str;
-    } else {
-      int length = str.length;
-      var s = _OneByteString._allocate(length);
-      for (int i = 0; i < length; i++) {
-        int currentUnit = str.codeUnitAt(i);
-        // All valid trimmed double strings must be ASCII.
-        if (currentUnit < 128) {
-          s._setAt(i, currentUnit);
-        } else {
-          return null;
-        }
-      }
-      oneByteString = s;
-    }
-
-    return _native_parse(oneByteString);
+    return _native_parse(str, start, end);
   }
 
   /* patch */ static double parse(String str,