Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: content/common/cc_messages_perftest.cc

Issue 368403003: Use RenderPass to create DrawQuad in unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@layerrawptrDQ
Patch Set: actually fix error this time Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/cc_messages_perftest.cc
diff --git a/content/common/cc_messages_perftest.cc b/content/common/cc_messages_perftest.cc
index 7589128c23b1c82a94c6f0eabfee3f1dda9f6002..1aa09e875d55512a48e7d61421a7d7f69a6afcb3 100644
--- a/content/common/cc_messages_perftest.cc
+++ b/content/common/cc_messages_perftest.cc
@@ -67,10 +67,9 @@ TEST_F(CCMessagesPerfTest, DelegatedFrame_ManyQuads_1_4000) {
scoped_ptr<RenderPass> render_pass = RenderPass::Create();
render_pass->CreateAndAppendSharedQuadState();
for (int i = 0; i < 4000; ++i) {
- render_pass->quad_list.push_back(
- PictureDrawQuad::Create().PassAs<DrawQuad>());
- render_pass->quad_list.back()->shared_quad_state =
- render_pass->shared_quad_state_list.back();
+ PictureDrawQuad* quad =
+ render_pass->CreateAndAppendDrawQuad<PictureDrawQuad>();
+ quad->shared_quad_state = render_pass->shared_quad_state_list.back();
}
frame->delegated_frame_data.reset(new DelegatedFrameData);
@@ -85,10 +84,9 @@ TEST_F(CCMessagesPerfTest, DelegatedFrame_ManyQuads_1_100000) {
scoped_ptr<RenderPass> render_pass = RenderPass::Create();
render_pass->CreateAndAppendSharedQuadState();
for (int i = 0; i < 100000; ++i) {
- render_pass->quad_list.push_back(
- PictureDrawQuad::Create().PassAs<DrawQuad>());
- render_pass->quad_list.back()->shared_quad_state =
- render_pass->shared_quad_state_list.back();
+ PictureDrawQuad* quad =
+ render_pass->CreateAndAppendDrawQuad<PictureDrawQuad>();
+ quad->shared_quad_state = render_pass->shared_quad_state_list.back();
}
frame->delegated_frame_data.reset(new DelegatedFrameData);
@@ -103,10 +101,9 @@ TEST_F(CCMessagesPerfTest, DelegatedFrame_ManyQuads_4000_4000) {
scoped_ptr<RenderPass> render_pass = RenderPass::Create();
for (int i = 0; i < 4000; ++i) {
render_pass->CreateAndAppendSharedQuadState();
- render_pass->quad_list.push_back(
- PictureDrawQuad::Create().PassAs<DrawQuad>());
- render_pass->quad_list.back()->shared_quad_state =
- render_pass->shared_quad_state_list.back();
+ PictureDrawQuad* quad =
+ render_pass->CreateAndAppendDrawQuad<PictureDrawQuad>();
+ quad->shared_quad_state = render_pass->shared_quad_state_list.back();
}
frame->delegated_frame_data.reset(new DelegatedFrameData);
@@ -121,10 +118,9 @@ TEST_F(CCMessagesPerfTest, DelegatedFrame_ManyQuads_100000_100000) {
scoped_ptr<RenderPass> render_pass = RenderPass::Create();
for (int i = 0; i < 100000; ++i) {
render_pass->CreateAndAppendSharedQuadState();
- render_pass->quad_list.push_back(
- PictureDrawQuad::Create().PassAs<DrawQuad>());
- render_pass->quad_list.back()->shared_quad_state =
- render_pass->shared_quad_state_list.back();
+ PictureDrawQuad* quad =
+ render_pass->CreateAndAppendDrawQuad<PictureDrawQuad>();
+ quad->shared_quad_state = render_pass->shared_quad_state_list.back();
}
frame->delegated_frame_data.reset(new DelegatedFrameData);
@@ -142,10 +138,9 @@ TEST_F(CCMessagesPerfTest,
scoped_ptr<RenderPass> render_pass = RenderPass::Create();
for (int j = 0; j < 100; ++j) {
render_pass->CreateAndAppendSharedQuadState();
- render_pass->quad_list.push_back(
- PictureDrawQuad::Create().PassAs<DrawQuad>());
- render_pass->quad_list.back()->shared_quad_state =
- render_pass->shared_quad_state_list.back();
+ PictureDrawQuad* quad =
+ render_pass->CreateAndAppendDrawQuad<PictureDrawQuad>();
+ quad->shared_quad_state = render_pass->shared_quad_state_list.back();
}
frame->delegated_frame_data->render_pass_list.push_back(render_pass.Pass());
}

Powered by Google App Engine
This is Rietveld 408576698