Virtual Keyboard: Update insets on change to window bounds.

ui/keyboard/keyboard_controller.cc

Index: ui/keyboard/keyboard_controller.cc
diff --git a/ui/keyboard/keyboard_controller.cc b/ui/keyboard/keyboard_controller.cc
index 1685451d32f433835afb163f79059c467de0dd97..56cf1589806ec83bdf03e96ba6c099ab100a64f2 100644
--- a/ui/keyboard/keyboard_controller.cc
+++ b/ui/keyboard/keyboard_controller.cc
@@ -11,6 +11,7 @@
 #include "content/public/browser/render_widget_host_view.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_delegate.h"
+#include "ui/aura/window_observer.h"
 #include "ui/base/cursor/cursor.h"
 #include "ui/base/hit_test.h"
 #include "ui/base/ime/input_method.h"
@@ -189,6 +190,20 @@ void CallbackAnimationObserver::OnLayerAnimationAborted(
   animator_->RemoveObserver(this);
 }
 
+class WindowBoundsChangeObserver : public aura::WindowObserver {
+ public:
+  virtual void OnWindowBoundsChanged(aura::Window* window,
+                                     const gfx::Rect& old_bounds,
+                                     const gfx::Rect& new_bounds) OVERRIDE;
+};
+
+void WindowBoundsChangeObserver::OnWindowBoundsChanged(aura::Window* window,
+    const gfx::Rect& old_bounds, const gfx::Rect& new_bounds) {
+  KeyboardController* controller =  KeyboardController::GetInstance();
+  if (controller)
+    controller->UpdateWindowInsets(window);
+}
+
 // static
 KeyboardController* KeyboardController::instance_ = NULL;
 
@@ -202,6 +217,7 @@ KeyboardController::KeyboardController(KeyboardControllerProxy* proxy)
   CHECK(proxy);
   input_method_ = proxy_->GetInputMethod();
   input_method_->AddObserver(this);
+  window_bounds_observer_.reset(new WindowBoundsChangeObserver());
 }
 
 KeyboardController::~KeyboardController() {
@@ -271,8 +287,7 @@ void KeyboardController::NotifyKeyboardBoundsChanging(
               view->SetInsets(gfx::Insets(0, 0, overlap, 0));
             else
               view->SetInsets(gfx::Insets(0, 0, 0, 0));
-            // TODO(kevers): Add window observer to native window to update
-            // insets on a window move or resize.
+            AddBoundsChangedObserver(window);
           }
         }
       }
@@ -384,6 +399,33 @@ void KeyboardController::OnShowImeIfNeeded() {
   ShowKeyboardInternal();
 }
 
+void KeyboardController::UpdateWindowInsets(aura::Window* window) {
+  aura::Window *keyboard_window = proxy_->GetKeyboardWindow();
+  if (window == keyboard_window)
+    return;
+
+  bool enableInsets = (keyboard_window->GetRootWindow() ==
+      window->GetRootWindow()) && keyboard::IsKeyboardOverscrollEnabled() &&
+      proxy_->HasKeyboardWindow() && proxy_->GetKeyboardWindow()->IsVisible();

[bshe, 2014/07/04 13:03:57]

nit: Do you need HasKeyboardWindow? It should always be true after you call
GetKeyboardWindow above.

[kevers, 2014/07/18 14:06:23]

Done.

+
+  scoped_ptr<content::RenderWidgetHostIterator> widgets(
+      content::RenderWidgetHost::GetRenderWidgetHosts());
+  while (content::RenderWidgetHost* widget = widgets->GetNextHost()) {
+    content::RenderWidgetHostView* view = widget->GetView();
+    if (view && window->Contains(view->GetNativeView())) {
+      gfx::Rect window_bounds = view->GetNativeView()->GetBoundsInScreen();
+      gfx::Rect intersect = gfx::IntersectRects(window_bounds,
+          proxy_->GetKeyboardWindow()->bounds());
+      int overlap = enableInsets ? intersect.height() : 0;
+      if (overlap > 0 && overlap < window_bounds.height())
+        view->SetInsets(gfx::Insets(0, 0, overlap, 0));
+      else
+        view->SetInsets(gfx::Insets(0, 0, 0, 0));

[bshe, 2014/07/04 13:03:57]

nit: probably gfx::Insets()?

[kevers, 2014/07/18 14:06:23]

Done.

+      return;
+    }
+  }
+}
+
 void KeyboardController::ShowKeyboardInternal() {
   if (!container_.get())
     return;
@@ -460,8 +502,11 @@ void KeyboardController::ResetWindowInsets() {
       content::RenderWidgetHost::GetRenderWidgetHosts());
   while (content::RenderWidgetHost* widget = widgets->GetNextHost()) {
     content::RenderWidgetHostView* view = widget->GetView();
-    if (view)
+    if (view) {
       view->SetInsets(insets);
+      aura::Window *window = view->GetNativeView();
+      RemoveBoundsChangedObserver(window);
+    }
   }
 }
 
@@ -480,4 +525,20 @@ void KeyboardController::HideAnimationFinished() {
   proxy_->HideKeyboardContainer(container_.get());
 }
 
+void KeyboardController::AddBoundsChangedObserver(aura::Window* window) {
+  while(window->parent() && window->parent()->id() < 0) {

[bshe, 2014/07/04 13:03:57]

nit: do you mind to add a comment on why do we check "id < 0"? Or maybe add an
anonymous function since this while loop doesn't depend on KeyboardController
and is used in more than one place.

[kevers, 2014/07/18 14:06:23]

Done.

+    window = window->parent();
+  }
+  if (!window->HasObserver(window_bounds_observer_.get()))
+    window->AddObserver(window_bounds_observer_.get());
+}
+
+void KeyboardController::RemoveBoundsChangedObserver(aura::Window* window) {
+  while(window->parent() && window->parent()->id() < 0) {
+    window = window->parent();
+  }
+  if (window && window->HasObserver(window_bounds_observer_.get()))

[bshe, 2014/07/04 13:03:57]

nit: you probably dont need to check if window is null in this if check or you
should probably check it before the while loop.

[kevers, 2014/07/18 14:06:23]

Done.

+    window->RemoveObserver(window_bounds_observer_.get());
+}
+
 }  // namespace keyboard