Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 368283003: Change AndroidHistoryProviderService to use CancelableTaskTracker (5/6) (Closed)

Created:
6 years, 5 months ago by sdefresne
Modified:
6 years, 5 months ago
Reviewers:
Miguel Garcia, blundell
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cancelable_task_tracker.5
Project:
chromium
Visibility:
Public.

Description

Change AndroidHistoryProviderService to use CancelableTaskTracker (5/6) Port UpdateHistoryAndBookmarks and UpdateSearchTerms to use a base::CancelableTaskTracker instead of a CancelableRequestConsumer. BUG=371818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284069

Patch Set 1 #

Total comments: 2

Patch Set 2 : clang-format #

Patch Set 3 : Document methods #

Patch Set 4 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -81 lines) Patch
M chrome/browser/android/provider/chrome_browser_provider.cc View 1 2 2 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/history/android/android_history_provider_service.h View 1 2 3 chunks +12 lines, -14 lines 0 comments Download
M chrome/browser/history/android/android_history_provider_service.cc View 1 2 chunks +32 lines, -20 lines 0 comments Download
M chrome/browser/history/android/android_history_provider_service_unittest.cc View 1 2 3 3 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 2 2 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/history/history_backend_android.cc View 2 chunks +8 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sdefresne
Could you please take a look? This is the fifth of a series of seven ...
6 years, 5 months ago (2014-07-03 17:19:46 UTC) #1
blundell
https://codereview.chromium.org/368283003/diff/1/chrome/browser/history/history_backend_android.cc File chrome/browser/history/history_backend_android.cc (left): https://codereview.chromium.org/368283003/diff/1/chrome/browser/history/history_backend_android.cc#oldcode41 chrome/browser/history/history_backend_android.cc:41: bool result = false; is it definitely safe to ...
6 years, 5 months ago (2014-07-04 10:04:15 UTC) #2
blundell
6 years, 5 months ago (2014-07-04 10:05:53 UTC) #3
blundell
actually, the success value wasn't even used by the callbacks, was it? LGTM
6 years, 5 months ago (2014-07-04 10:07:46 UTC) #4
sdefresne
+miguelg for OWNERS of //chrome/browser/android
6 years, 5 months ago (2014-07-04 12:27:07 UTC) #5
Miguel Garcia
LGTM the usual request to document the methods where you've changed the signature
6 years, 5 months ago (2014-07-07 09:55:58 UTC) #6
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 5 months ago (2014-07-18 10:16:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/368283003/60001
6 years, 5 months ago (2014-07-18 10:17:32 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 12:57:07 UTC) #9
Message was sent while issue was closed. 
Change committed as 284069

Powered by Google App Engine
This is Rietveld 408576698