Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/browser/android/provider/chrome_browser_provider.cc

Issue 368283003: Change AndroidHistoryProviderService to use CancelableTaskTracker (5/6) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cancelable_task_tracker.5
Patch Set: Fix unit tests Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/history/android/android_history_provider_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/provider/chrome_browser_provider.cc
diff --git a/chrome/browser/android/provider/chrome_browser_provider.cc b/chrome/browser/android/provider/chrome_browser_provider.cc
index b50528be5b9318ea9aef150a671929406b3e57b5..904acc84602bd31d8d8f8f1139543f7d7f68dea5 100644
--- a/chrome/browser/android/provider/chrome_browser_provider.cc
+++ b/chrome/browser/android/provider/chrome_browser_provider.cc
@@ -817,17 +817,18 @@ class UpdateBookmarksFromAPITask : public HistoryProviderTask {
const std::vector<base::string16>& selection_args) {
RunAsyncRequestOnUIThreadBlocking(
base::Bind(&AndroidHistoryProviderService::UpdateHistoryAndBookmarks,
- base::Unretained(service()), row, selection,
- selection_args, cancelable_consumer(),
+ base::Unretained(service()),
+ row,
+ selection,
+ selection_args,
base::Bind(&UpdateBookmarksFromAPITask::OnBookmarksUpdated,
- base::Unretained(this))));
+ base::Unretained(this)),
+ cancelable_tracker()));
return result_;
}
private:
- void OnBookmarksUpdated(AndroidHistoryProviderService::Handle handle,
- bool succeeded,
- int updated_row_count) {
+ void OnBookmarksUpdated(int updated_row_count) {
result_ = updated_row_count;
RequestCompleted();
}
@@ -1063,15 +1064,12 @@ class UpdateSearchTermsFromAPITask : public SearchTermTask {
internal_row,
selection,
selection_args,
- cancelable_consumer(),
base::Bind(&UpdateSearchTermsFromAPITask::OnSearchTermsUpdated,
- base::Unretained(this)));
+ base::Unretained(this)),
+ cancelable_tracker());
}
-
- void OnSearchTermsUpdated(AndroidHistoryProviderService::Handle handle,
- bool succeeded,
- int updated_row_count) {
+ void OnSearchTermsUpdated(int updated_row_count) {
result_ = updated_row_count;
RequestCompleted();
}
« no previous file with comments | « no previous file | chrome/browser/history/android/android_history_provider_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698